Skip to content

run-make: vendor cargo dependencies or external dependencies within the tests #128733

Open
@jieyouxu

Description

@jieyouxu
  • tests/run-make/thumb-none-qemu
  • tests/run-make/x86_64-fortanix-unknown-sgx-lvi
  • tests/run-make/thumb-none-cortex-m (uses git clone too)

These tests use cargo to build crates but they have external dependencies -- this makes their pass/fail status conditioned on internet connectivity which does not seem ideal (and also if it's not pinned and it can become awkward from breakages..)

We should investigate if we could vendor the external deps or otherwise make them locally available to make the test outcomes more reproducible.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-run-makeArea: port run-make Makefiles to rmake.rsA-testsuiteArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions