Skip to content

compiletest: don't silently accept unsupported directives in test suites #128058

Open
@jieyouxu

Description

Yes, there are special handling here and there for specific directives. But the handling is limited and is only for specific directives in specific test suites.

We should error if a test writer specifies a directive invalid for a given test suite.

This may require reworking how directives are handled, i.e. have test suites "register" what directives they support.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    A-compiletestArea: The compiletest test runnerA-contributor-roadblockArea: Makes things more difficult for new contributors to rust itselfC-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-hardCall for participation: Hard difficulty. Experience needed to fix: A lot.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions