Open
Description
openedon Jul 20, 2024
I was somewhat thrown off by 6062059#diff-675065335a90de4a4e1ac5bc0a078709f865ff2d357ba2650309f0ad8614b1d3R3531-R3549; setting Mode::ToolStd or some of the other Mode::Tool* options caused a can't find crate for `core` (and std) error. This was fixed by adding builder.ensure(compile::Std::new(compiler, bootstrap_host));.
Since prepare_tool_cargo knows the mode, it should just call builder.ensure itself. This manual ensure could then be removed from the rest of build_steps/test.rs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Metadata
Assignees
Labels
Area: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)