Skip to content

Fix internal Wtf8Buf::extend_from_slice check #126977

Closed
@Borgerr

Description

@Borgerr

Reviewing PR #126885 had some oversight regarding valid utf8 checks. This was graciously brought to our (meaning myself and @workingjubilee) attention by @yhx-12243 in this comment. Fix should really just be changing line 483 of wtf8.rs to setting self.is_known_utf8 to false, unless we decide there may be some merit to iterating again through the other buffer.

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.O-windowsOperating system: WindowsT-libsRelevant to the library team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions