Skip to content

We should document more clearly env vars used between bootstrap <-> compiletest <-> test suites #125587

Open

Description

Location

bootstrap <-> compiletest <-> testsuites

Summary

In tests/run-make (for example, but the lack of docs isn't limited to this particular test suite) we assume a bunch of env vars being available, but AFAIK there isn't any docs on which env vars are assumed available between the bootstrap -> compiletest -> test suites pipeline and for what reasons. It'd be nice to have any kind of docs on them.

The current state is that:

  • bootstrap sets up a bunch of env vars, which are made available to compiletest
  • compiletest assumes bootstrap-set env vars are available
  • compiletest sets up a bunch of env vars, often conditionally available to specific test suites
  • tests inside test suites assume compiletest-set env vars are available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    A-compiletestArea: The compiletest test runnerA-docsArea: documentation for any part of the project, including the compiler, standard library, and toolsA-testsuiteArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.E-tediousCall for participation: An issue involves lots of work and is better handled as many small tasks.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions