Skip to content

Add fast path to bypass upcall_require on crate cache hit. #12

Closed
@graydon

Description

@graydon

We always do one upcall_import to access the crate-cache, even though on a cache hit the upcall is not doing anything more complex than a couple indexed-load-and-compare checks and a return.

This is not necessary: we can emit those load/compare checks as a fast(er) hit path that stays in the stub, and only upcall on miss.

Deferring for now because it's still not a big cost at the moment, and there's more work to do around the stubs anyways in terms of refcounting.

Metadata

Metadata

Assignees

No one assigned

    Labels

    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions