Skip to content

consider bannig empty panic/unreachable/ bugs from rustc codebase #118955

Open
@matthiaskrgr

Description

@matthiaskrgr
git grep "[^e]bug\!()" compiler   130 
git grep "panic\!()" compiler  43 
git grep "unreachable\!()" compiler  384

I wonder if it makes sense to try to fill these up with at least somewhat contextual error/ice messages instead of just a "panicked at" or "impossible case reached"?

Unfortunately I could not find a rustc lint that warns on empty panics like these

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustA-metaArea: Issues & PRs about the rust-lang/rust repository itselfC-cleanupCategory: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions