-
-
Notifications
You must be signed in to change notification settings - Fork 16.8k
hint users to update nightly on ICEs of outdated nightly #118832
Copy link
Copy link
Closed
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
Activity
Metadata
Metadata
Assignees
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
From time to time we get reports of regressions that have already been fixed since several days, but the user uses a nightly that is 1-2 weeks old for example.
We could probably make nightly somewhat self-aware and make it:
grab the current date and compare it to its own version string
calculate when
$current_versionwas released (iirc the time when the master-> nightly promotion happens can be found on the forge somewhere) and add maybe 6 to 12 hours as buffer.If
$current_version.release_timestampis older than $current_time + 24 hours + buffer and nightly crashes, add a hint to perhaps update to the user but only iff we are on the master/nightly channel!could look like this:
We could also consider hiding/adapting the
we would appreciate a bug reportline in case we detected a potentially outdated nightly.