`rustdoc --version --verbose` no longer displays commit hashes + date since beta 1.67

[matthiaskrgr]

stable is fine:
~/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/rustdoc --version --verbose

rustdoc 1.66.1 (90743e729 2023-01-10)
binary: rustdoc
commit-hash: 90743e7298aca107ddaa0c202a4d3604e29bfeb6
commit-date: 2023-01-10
host: x86_64-unknown-linux-gnu
release: 1.66.1
LLVM version: 15.0.2

but beta and nightly are no longer showing commit-hash and commit-date information:
~/.rustup/toolchains/beta-x86_64-unknown-linux-gnu/bin/rustdoc --version --verbose

rustdoc 1.67.0-beta.8 (7a9ae0ce6 2023-01-14)
binary: rustdoc
commit-hash: unknown
commit-date: unknown
host: x86_64-unknown-linux-gnu
release: 1.67.0-beta.8
LLVM version: 15.0.6

~/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/rustdoc --version --verbose

rustdoc 1.68.0-nightly (333ee6c46 2023-01-18)
binary: rustdoc
commit-hash: unknown
commit-date: unknown
host: x86_64-unknown-linux-gnu
release: 1.68.0-nightly
LLVM version: 15.0.6

[matthiaskrgr]

it's weird because the info is still displayed correctly in the very first oneliner-summary, but if there was some tool that reads the data by looking at commit-hash or commit-date we still should display the right thing.

[ehuss]

This appears to have been introduced by #104184. The issue is that the macro uses CFG_VER_DATE/CFG_VER_HASH which is only set when compiling rustc.

One option is to try to share some code with rustc_cargo_env. Another option is to go the other way and get rustc to share some code with prepare_tool_cargo.

[jyn514]

Mentoring instructions: set

rust/src/bootstrap/compile.rs

Lines 792 to 794 in 4e163af

	if let Some(ref ver_date) = builder.rust_info().commit_date() {
	cargo.env("CFG_VER_DATE", ver_date);
	}

in

rust/src/bootstrap/tool.rs

Line 235 in 7c3f0d6

pub fn prepare_tool_cargo(

(Maybe we should try to unify those functions so they don't duplicate so much code and problems like this don't happen in the future?)