Skip to content

Bootstrap panics when running x fmt --check #100258

Closed
@camelid

Description

@camelid

I ran x fmt --check and got this panic, although the rustfmt output had already been printed:

If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.
thread 'thread '<unnamed><unnamed>' panicked at '' panicked at 'tx.send(entry.into_path()) failed with sending on a closed channeltx.send(entry.into_path()) failed with sending on a closed channel', ', format.rsformat.rs::166166::1717

note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Any { .. }', /Users/noahlev/.cargo/registry/src/github.com-1ecc6299db9ec823/ignore-0.4.18/src/walk.rs:1302:31
Build completed unsuccessfully in 0:00:07

Notably after running x fmt, the panic stops (and x fmt doesn't panic either). But reintroducing something where rustfmt will suggest changes brings the panic in --check back.

See previous discussion at this Zulip thread.

cc @jyn514

Metadata

Metadata

Assignees

Labels

C-bugCategory: This is a bug.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions