remove unecessary assert, and improve others

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Author: vincenzopalazzo

library/std/src/sys/unix/fs.rs

@@ -636,7 +636,7 @@ impl Iterator for ReadDir {
 impl Drop for Dir {
     fn drop(&mut self) {
         let r = unsafe { libc::closedir(self.0) };
-        assert_eq!(r, 0, "unexpected error during closedir: {:?}", r);
+        assert!(r == 0 || r == libc::EINTR, "unexpected error during closedir: {:?}", r);
     }
 }
 

library/std/src/sys/unix/locks/pthread_condvar.rs

@@ -186,7 +186,7 @@ impl Condvar {
         let r = libc::pthread_cond_timedwait(self.inner.get(), pthread_mutex::raw(mutex), &timeout);
         assert!(
             r == libc::ETIMEDOUT || r == 0,
-            "unexpected error during pthread_conf_timedwait: {:?}",
+            "unexpected error during pthread_cond_timedwait: {:?}",
             r
         );
 

library/std/src/sys/unix/locks/pthread_rwlock.rs

@@ -110,8 +110,6 @@ impl RwLock {
             }
             panic!("rwlock write lock would result in deadlock");
         } else {
-            // According to POSIX, for a properly initialized rwlock this can only
-            // return EDEADLK or 0. We rely on that.
             assert_eq!(r, 0, "unexpected error during pthread_rwlock_wrlock: {:?}", r);
         }
         *self.write_locked.get() = true;

library/std/src/sys/unix/thread.rs

@@ -112,8 +112,7 @@ impl Thread {
     }
 
     pub fn yield_now() {
-        let ret = unsafe { libc::sched_yield() };
-        assert_eq!(ret, 0, "unexpected error during sched_yield: {:?}", ret);
+        let _ = unsafe { libc::sched_yield() };
     }
 
     #[cfg(any(target_os = "linux", target_os = "android"))]