From f87afe54b87586a80b9a2b8e0193c933ef763e6d Mon Sep 17 00:00:00 2001 From: hyd-dev Date: Sun, 7 Feb 2021 00:20:55 +0800 Subject: [PATCH] Extend the comment of `check_toolstate()` to clarify that the tool won't be shipped on all targets --- src/tools/build-manifest/src/main.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/tools/build-manifest/src/main.rs b/src/tools/build-manifest/src/main.rs index 9eeeb409d44e0..d7c2fb8c8b893 100644 --- a/src/tools/build-manifest/src/main.rs +++ b/src/tools/build-manifest/src/main.rs @@ -254,7 +254,10 @@ impl Builder { t!(self.checksums.store_cache()); } - /// If a tool does not pass its tests, don't ship it. + /// If a tool does not pass its tests on *any* of Linux and Windows, don't ship + /// it on *all* targets, because tools like Miri can "cross-run" programs for + /// different targets, for example, run a program for `x86_64-pc-windows-msvc` + /// on `x86_64-unknown-linux-gnu`. /// Right now, we do this only for Miri. fn check_toolstate(&mut self) { for file in &["toolstates-linux.json", "toolstates-windows.json"] {