Skip to content

Commit

Permalink
Rollup merge of #128755 - yaahc:jj-crlf, r=estebank
Browse files Browse the repository at this point in the history
Integrate crlf directly into related test file instead via of .gitattributes

resolves #128708

This PR seeks to resolve a contributor papercut when using jj to manage the git repo locally which does not support .gitattributes. It does so by integrating the crlf characters directly into the related test and disabling Git's end of line normalization logic across platforms for that specific file, instead of configuring git to always check out the files with alternative eol characters.

related documentation: https://git-scm.com/docs/gitattributes#Documentation/gitattributes.txt-Unset-1
  • Loading branch information
matthiaskrgr authored Aug 7, 2024
2 parents 8f5b50d + b174cf8 commit e5a3c32
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 27 deletions.
2 changes: 1 addition & 1 deletion tests/rustdoc-ui/intra-doc/.gitattributes
Original file line number Diff line number Diff line change
@@ -1 +1 @@
warning-crlf.rs eol=crlf
warning-crlf.rs -text
52 changes: 26 additions & 26 deletions tests/rustdoc-ui/intra-doc/warning-crlf.rs
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
// ignore-tidy-cr
//@ check-pass

// This file checks the spans of intra-link warnings in a file with CRLF line endings. The
// .gitattributes file in this directory should enforce it.

/// [error]
pub struct A;
//~^^ WARNING `error`

///
/// docs [error1]
//~^ WARNING `error1`

/// docs [error2]
///
pub struct B;
//~^^^ WARNING `error2`

/**
* This is a multi-line comment.
*
* It also has an [error].
*/
pub struct C;
//~^^^ WARNING `error`
// ignore-tidy-cr
//@ check-pass

// This file checks the spans of intra-link warnings in a file with CRLF line endings. The
// .gitattributes file in this directory should enforce it.

/// [error]
pub struct A;
//~^^ WARNING `error`

///
/// docs [error1]
//~^ WARNING `error1`

/// docs [error2]
///
pub struct B;
//~^^^ WARNING `error2`

/**
* This is a multi-line comment.
*
* It also has an [error].
*/
pub struct C;
//~^^^ WARNING `error`

0 comments on commit e5a3c32

Please sign in to comment.