fix nits

Author: wiomoc

clippy_lints/src/needless_arbitrary_self_type.rs

@@ -82,7 +82,7 @@ fn check_param_inner(cx: &EarlyContext<'_>, path: &Path, span: Span, binding_mod
                 cx,
                 NEEDLESS_ARBITRARY_SELF_TYPE,
                 span,
-                "the type of the `self` parameter is arbitrary",
+                "the type of the `self` parameter does not need to be arbitrary",
                 "consider to change this parameter to",
                 self_param,
                 Applicability::MachineApplicable,

tests/ui/needless_arbitrary_self_type.fixed

@@ -29,23 +29,31 @@ impl ValType {
         unimplemented!();
     }
 
+    pub fn ref_good(&self) {
+        unimplemented!();
+    }
+
     pub fn ref_bad_with_lifetime<'a>(&'a self) {
         unimplemented!();
     }
 
-    pub fn ref_good(&self) {
+    pub fn ref_good_with_lifetime<'a>(&'a self) {
         unimplemented!();
     }
 
     pub fn mut_ref_bad(&mut self) {
         unimplemented!();
     }
 
+    pub fn mut_ref_good(&mut self) {
+        unimplemented!();
+    }
+
     pub fn mut_ref_bad_with_lifetime<'a>(&'a mut self) {
         unimplemented!();
     }
 
-    pub fn mut_ref_good(&mut self) {
+    pub fn mut_ref_good_with_lifetime<'a>(&'a mut self) {
         unimplemented!();
     }
 

tests/ui/needless_arbitrary_self_type.rs

@@ -29,23 +29,31 @@ impl ValType {
         unimplemented!();
     }
 
+    pub fn ref_good(&self) {
+        unimplemented!();
+    }
+
     pub fn ref_bad_with_lifetime<'a>(self: &'a Self) {
         unimplemented!();
     }
 
-    pub fn ref_good(&self) {
+    pub fn ref_good_with_lifetime<'a>(&'a self) {
         unimplemented!();
     }
 
     pub fn mut_ref_bad(self: &mut Self) {
         unimplemented!();
     }
 
+    pub fn mut_ref_good(&mut self) {
+        unimplemented!();
+    }
+
     pub fn mut_ref_bad_with_lifetime<'a>(self: &'a mut Self) {
         unimplemented!();
     }
 
-    pub fn mut_ref_good(&mut self) {
+    pub fn mut_ref_good_with_lifetime<'a>(&'a mut self) {
         unimplemented!();
     }
 

tests/ui/needless_arbitrary_self_type.stderr

@@ -1,43 +1,43 @@
-error: the type of the `self` parameter is arbitrary
+error: the type of the `self` parameter does not need to be arbitrary
   --> $DIR/needless_arbitrary_self_type.rs:12:16
    |
 LL |     pub fn bad(self: Self) {
    |                ^^^^^^^^^^ help: consider to change this parameter to: `self`
    |
    = note: `-D clippy::needless-arbitrary-self-type` implied by `-D warnings`
 
-error: the type of the `self` parameter is arbitrary
+error: the type of the `self` parameter does not need to be arbitrary
   --> $DIR/needless_arbitrary_self_type.rs:20:20
    |
 LL |     pub fn mut_bad(mut self: Self) {
    |                    ^^^^^^^^^^^^^^ help: consider to change this parameter to: `mut self`
 
-error: the type of the `self` parameter is arbitrary
+error: the type of the `self` parameter does not need to be arbitrary
   --> $DIR/needless_arbitrary_self_type.rs:28:20
    |
 LL |     pub fn ref_bad(self: &Self) {
    |                    ^^^^^^^^^^^ help: consider to change this parameter to: `&self`
 
-error: the type of the `self` parameter is arbitrary
-  --> $DIR/needless_arbitrary_self_type.rs:32:38
+error: the type of the `self` parameter does not need to be arbitrary
+  --> $DIR/needless_arbitrary_self_type.rs:36:38
    |
 LL |     pub fn ref_bad_with_lifetime<'a>(self: &'a Self) {
    |                                      ^^^^^^^^^^^^^^ help: consider to change this parameter to: `&'a self`
 
-error: the type of the `self` parameter is arbitrary
-  --> $DIR/needless_arbitrary_self_type.rs:40:24
+error: the type of the `self` parameter does not need to be arbitrary
+  --> $DIR/needless_arbitrary_self_type.rs:44:24
    |
 LL |     pub fn mut_ref_bad(self: &mut Self) {
    |                        ^^^^^^^^^^^^^^^ help: consider to change this parameter to: `&mut self`
 
-error: the type of the `self` parameter is arbitrary
-  --> $DIR/needless_arbitrary_self_type.rs:44:42
+error: the type of the `self` parameter does not need to be arbitrary
+  --> $DIR/needless_arbitrary_self_type.rs:52:42
    |
 LL |     pub fn mut_ref_bad_with_lifetime<'a>(self: &'a mut Self) {
    |                                          ^^^^^^^^^^^^^^^^^^ help: consider to change this parameter to: `&'a mut self`
 
-error: the type of the `self` parameter is arbitrary
-  --> $DIR/needless_arbitrary_self_type.rs:52:28
+error: the type of the `self` parameter does not need to be arbitrary
+  --> $DIR/needless_arbitrary_self_type.rs:60:28
    |
 LL |     pub fn mut_ref_mut_bad(mut self: &mut Self) {
    |                            ^^^^^^^^^^^^^^^^^^^ help: consider to change this parameter to: `&mut self`