Skip to content

Commit dec1d16

Browse files
committed
Give an item related to issue 27438 a more meaningful name
1 parent 9e739b7 commit dec1d16

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

compiler/rustc_data_structures/src/lib.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -144,9 +144,9 @@ pub fn make_display(f: impl Fn(&mut fmt::Formatter<'_>) -> fmt::Result) -> impl
144144
Printer { f }
145145
}
146146

147-
// See comments in compiler/rustc_middle/src/tests.rs
147+
// See comment in compiler/rustc_middle/src/tests.rs and issue #27438.
148148
#[doc(hidden)]
149-
pub fn __noop_fix_for_27438() {}
149+
pub fn __noop_fix_for_windows_dllimport_issue() {}
150150

151151
#[macro_export]
152152
macro_rules! external_bitflags_debug {

compiler/rustc_middle/src/tests.rs

+6-8
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
1-
// FIXME(#27438): right now the unit tests of rustc_middle don't refer to any actual
2-
// functions generated in rustc_data_structures (all
3-
// references are through generic functions), but statics are
4-
// referenced from time to time. Due to this bug we won't
5-
// actually correctly link in the statics unless we also
6-
// reference a function, so be sure to reference a dummy
7-
// function.
1+
// FIXME(#27438): Right now, the unit tests of `rustc_middle` don't refer to any actual functions
2+
// generated in `rustc_data_structures` (all references are through generic functions),
3+
// but statics are referenced from time to time. Due to this Windows `dllimport` bug
4+
// we won't actually correctly link in the statics unless we also reference a function,
5+
// so be sure to reference a dummy function.
86
#[test]
97
fn noop() {
10-
rustc_data_structures::__noop_fix_for_27438();
8+
rustc_data_structures::__noop_fix_for_windows_dllimport_issue();
119
}

0 commit comments

Comments
 (0)