Skip to content

Commit

Permalink
Try to recover from a => -> = or -> typo in a match arm
Browse files Browse the repository at this point in the history
  • Loading branch information
FabianWolff committed Oct 3, 2021
1 parent edebf77 commit cf19131
Show file tree
Hide file tree
Showing 4 changed files with 67 additions and 1 deletion.
16 changes: 15 additions & 1 deletion compiler/rustc_parse/src/parser/expr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2322,7 +2322,21 @@ impl<'a> Parser<'a> {
None
};
let arrow_span = this.token.span;
this.expect(&token::FatArrow)?;
if let Err(mut err) = this.expect(&token::FatArrow) {
// We might have a `=>` -> `=` or `->` typo (issue #89396).
if let token::Eq | token::RArrow = this.token.kind {
err.span_suggestion(
this.token.span,
"try using a fat arrow here",
"=>".to_string(),
Applicability::MaybeIncorrect,
);
err.emit();
this.bump();
} else {
return Err(err);
}
}
let arm_start_span = this.token.span;

let expr = this.parse_expr_res(Restrictions::STMT_EXPR, None).map_err(|mut err| {
Expand Down
16 changes: 16 additions & 0 deletions src/test/ui/parser/issue-89396.fixed
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// Regression test for issue #89396: Try to recover from a
// `=>` -> `=` or `->` typo in a match arm.

// run-rustfix

fn main() {
let opt = Some(42);
let _ = match opt {
Some(_) => true,
//~^ ERROR: expected one of
//~| HELP: try using a fat arrow here
None => false,
//~^ ERROR: expected one of
//~| HELP: try using a fat arrow here
};
}
16 changes: 16 additions & 0 deletions src/test/ui/parser/issue-89396.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// Regression test for issue #89396: Try to recover from a
// `=>` -> `=` or `->` typo in a match arm.

// run-rustfix

fn main() {
let opt = Some(42);
let _ = match opt {
Some(_) = true,
//~^ ERROR: expected one of
//~| HELP: try using a fat arrow here
None -> false,
//~^ ERROR: expected one of
//~| HELP: try using a fat arrow here
};
}
20 changes: 20 additions & 0 deletions src/test/ui/parser/issue-89396.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
error: expected one of `=>`, `if`, or `|`, found `=`
--> $DIR/issue-89396.rs:9:17
|
LL | Some(_) = true,
| ^
| |
| expected one of `=>`, `if`, or `|`
| help: try using a fat arrow here: `=>`

error: expected one of `=>`, `@`, `if`, or `|`, found `->`
--> $DIR/issue-89396.rs:12:14
|
LL | None -> false,
| ^^
| |
| expected one of `=>`, `@`, `if`, or `|`
| help: try using a fat arrow here: `=>`

error: aborting due to 2 previous errors

0 comments on commit cf19131

Please sign in to comment.