Skip to content

Commit cb87a24

Browse files
authored
Unrolled build for #143685
Rollup merge of #143685 - LorrensP-2158466:merge-import-bindings, r=petrochenkov Resolve: merge `source_bindings` and `target_bindings` into `bindings` Attempts to merge the 2 fields `source_bindings` and `target_bindings` of `ImportKind::Single` into 1 field called `bindings`. r? ````@petrochenkov````
2 parents 7e310f4 + e3fc6e5 commit cb87a24

File tree

4 files changed

+123
-136
lines changed

4 files changed

+123
-136
lines changed

compiler/rustc_resolve/src/build_reduced_graph.rs

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,9 @@ use crate::def_collector::collect_definitions;
3232
use crate::imports::{ImportData, ImportKind};
3333
use crate::macros::{MacroRulesBinding, MacroRulesScope, MacroRulesScopeRef};
3434
use crate::{
35-
BindingKey, Determinacy, ExternPreludeEntry, Finalize, MacroData, Module, ModuleKind,
36-
ModuleOrUniformRoot, NameBinding, NameBindingData, NameBindingKind, ParentScope, PathResult,
37-
ResolutionError, Resolver, ResolverArenas, Segment, ToNameBinding, Used, VisResolutionError,
38-
errors,
35+
BindingKey, ExternPreludeEntry, Finalize, MacroData, Module, ModuleKind, ModuleOrUniformRoot,
36+
NameBinding, NameBindingData, NameBindingKind, ParentScope, PathResult, ResolutionError,
37+
Resolver, ResolverArenas, Segment, ToNameBinding, Used, VisResolutionError, errors,
3938
};
4039

4140
type Res = def::Res<NodeId>;
@@ -620,16 +619,7 @@ impl<'a, 'ra, 'tcx> BuildReducedGraphVisitor<'a, 'ra, 'tcx> {
620619
let kind = ImportKind::Single {
621620
source: source.ident,
622621
target: ident,
623-
source_bindings: PerNS {
624-
type_ns: Cell::new(Err(Determinacy::Undetermined)),
625-
value_ns: Cell::new(Err(Determinacy::Undetermined)),
626-
macro_ns: Cell::new(Err(Determinacy::Undetermined)),
627-
},
628-
target_bindings: PerNS {
629-
type_ns: Cell::new(None),
630-
value_ns: Cell::new(None),
631-
macro_ns: Cell::new(None),
632-
},
622+
bindings: Default::default(),
633623
type_ns_only,
634624
nested,
635625
id,

compiler/rustc_resolve/src/ident.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1090,14 +1090,13 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
10901090
let Some(module) = single_import.imported_module.get() else {
10911091
return true;
10921092
};
1093-
let ImportKind::Single { source, target, target_bindings, .. } = &single_import.kind
1094-
else {
1093+
let ImportKind::Single { source, target, bindings, .. } = &single_import.kind else {
10951094
unreachable!();
10961095
};
10971096
if source != target {
1098-
if target_bindings.iter().all(|binding| binding.get().is_none()) {
1097+
if bindings.iter().all(|binding| binding.get().binding().is_none()) {
10991098
return true;
1100-
} else if target_bindings[ns].get().is_none() && binding.is_some() {
1099+
} else if bindings[ns].get().binding().is_none() && binding.is_some() {
11011100
return true;
11021101
}
11031102
}

0 commit comments

Comments
 (0)