Skip to content

Commit c35a2ce

Browse files
compiler-errorscompiler-errors
committed
add TyCtxt::as_lang_item, use in new solver
1 parent d1b7355 commit c35a2ce

File tree

5 files changed

+118
-68
lines changed

5 files changed

+118
-68
lines changed

‎compiler/rustc_hir/src/lang_items.rs

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ use crate::def_id::DefId;
1111
use crate::{MethodKind, Target};
1212

1313
use rustc_ast as ast;
14+
use rustc_data_structures::fx::FxIndexMap;
1415
use rustc_data_structures::stable_hasher::{HashStable, StableHasher};
1516
use rustc_macros::{Decodable, Encodable, HashStable_Generic};
1617
use rustc_span::symbol::{kw, sym, Symbol};
@@ -23,14 +24,19 @@ pub struct LanguageItems {
2324
/// Mappings from lang items to their possibly found [`DefId`]s.
2425
/// The index corresponds to the order in [`LangItem`].
2526
items: [Option<DefId>; std::mem::variant_count::<LangItem>()],
27+
reverse_items: FxIndexMap<DefId, LangItem>,
2628
/// Lang items that were not found during collection.
2729
pub missing: Vec<LangItem>,
2830
}
2931

3032
impl LanguageItems {
3133
/// Construct an empty collection of lang items and no missing ones.
3234
pub fn new() -> Self {
33-
Self { items: [None; std::mem::variant_count::<LangItem>()], missing: Vec::new() }
35+
Self {
36+
items: [None; std::mem::variant_count::<LangItem>()],
37+
reverse_items: FxIndexMap::default(),
38+
missing: Vec::new(),
39+
}
3440
}
3541

3642
pub fn get(&self, item: LangItem) -> Option<DefId> {
@@ -39,6 +45,11 @@ impl LanguageItems {
3945

4046
pub fn set(&mut self, item: LangItem, def_id: DefId) {
4147
self.items[item as usize] = Some(def_id);
48+
self.reverse_items.insert(def_id, item);
49+
}
50+
51+
pub fn from_def_id(&self, def_id: DefId) -> Option<LangItem> {
52+
self.reverse_items.get(&def_id).copied()
4253
}
4354

4455
pub fn iter(&self) -> impl Iterator<Item = (LangItem, DefId)> + '_ {

‎compiler/rustc_middle/src/middle/lang_items.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@ impl<'tcx> TyCtxt<'tcx> {
2727
self.lang_items().get(lang_item) == Some(def_id)
2828
}
2929

30+
pub fn as_lang_item(self, def_id: DefId) -> Option<LangItem> {
31+
self.lang_items().from_def_id(def_id)
32+
}
33+
3034
/// Given a [`DefId`] of one of the [`Fn`], [`FnMut`] or [`FnOnce`] traits,
3135
/// returns a corresponding [`ty::ClosureKind`].
3236
/// For any other [`DefId`] return `None`.

‎compiler/rustc_middle/src/ty/context.rs

Lines changed: 53 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -366,6 +366,10 @@ impl<'tcx> Interner for TyCtxt<'tcx> {
366366
self.is_lang_item(def_id, trait_lang_item_to_lang_item(lang_item))
367367
}
368368

369+
fn as_lang_item(self, def_id: DefId) -> Option<TraitSolverLangItem> {
370+
lang_item_to_trait_lang_item(self.lang_items().from_def_id(def_id)?)
371+
}
372+
369373
fn associated_type_def_ids(self, def_id: DefId) -> impl IntoIterator<Item = DefId> {
370374
self.associated_items(def_id)
371375
.in_definition_order()
@@ -584,41 +588,58 @@ impl<'tcx> Interner for TyCtxt<'tcx> {
584588
}
585589
}
586590

587-
fn trait_lang_item_to_lang_item(lang_item: TraitSolverLangItem) -> LangItem {
588-
match lang_item {
589-
TraitSolverLangItem::AsyncDestruct => LangItem::AsyncDestruct,
590-
TraitSolverLangItem::AsyncFnKindHelper => LangItem::AsyncFnKindHelper,
591-
TraitSolverLangItem::AsyncFnKindUpvars => LangItem::AsyncFnKindUpvars,
592-
TraitSolverLangItem::AsyncFnOnceOutput => LangItem::AsyncFnOnceOutput,
593-
TraitSolverLangItem::AsyncIterator => LangItem::AsyncIterator,
594-
TraitSolverLangItem::CallOnceFuture => LangItem::CallOnceFuture,
595-
TraitSolverLangItem::CallRefFuture => LangItem::CallRefFuture,
596-
TraitSolverLangItem::Clone => LangItem::Clone,
597-
TraitSolverLangItem::Copy => LangItem::Copy,
598-
TraitSolverLangItem::Coroutine => LangItem::Coroutine,
599-
TraitSolverLangItem::CoroutineReturn => LangItem::CoroutineReturn,
600-
TraitSolverLangItem::CoroutineYield => LangItem::CoroutineYield,
601-
TraitSolverLangItem::Destruct => LangItem::Destruct,
602-
TraitSolverLangItem::DiscriminantKind => LangItem::DiscriminantKind,
603-
TraitSolverLangItem::DynMetadata => LangItem::DynMetadata,
604-
TraitSolverLangItem::FnPtrTrait => LangItem::FnPtrTrait,
605-
TraitSolverLangItem::FusedIterator => LangItem::FusedIterator,
606-
TraitSolverLangItem::Future => LangItem::Future,
607-
TraitSolverLangItem::FutureOutput => LangItem::FutureOutput,
608-
TraitSolverLangItem::Iterator => LangItem::Iterator,
609-
TraitSolverLangItem::Metadata => LangItem::Metadata,
610-
TraitSolverLangItem::Option => LangItem::Option,
611-
TraitSolverLangItem::PointeeTrait => LangItem::PointeeTrait,
612-
TraitSolverLangItem::PointerLike => LangItem::PointerLike,
613-
TraitSolverLangItem::Poll => LangItem::Poll,
614-
TraitSolverLangItem::Sized => LangItem::Sized,
615-
TraitSolverLangItem::TransmuteTrait => LangItem::TransmuteTrait,
616-
TraitSolverLangItem::Tuple => LangItem::Tuple,
617-
TraitSolverLangItem::Unpin => LangItem::Unpin,
618-
TraitSolverLangItem::Unsize => LangItem::Unsize,
591+
macro_rules! bidirectional_lang_item_map {
592+
($($name:ident),+ $(,)?) => {
593+
fn trait_lang_item_to_lang_item(lang_item: TraitSolverLangItem) -> LangItem {
594+
match lang_item {
595+
$(TraitSolverLangItem::$name => LangItem::$name,)+
596+
}
597+
}
598+
599+
fn lang_item_to_trait_lang_item(lang_item: LangItem) -> Option<TraitSolverLangItem> {
600+
Some(match lang_item {
601+
$(LangItem::$name => TraitSolverLangItem::$name,)+
602+
_ => return None,
603+
})
604+
}
619605
}
620606
}
621607

608+
bidirectional_lang_item_map! {
609+
// tidy-alphabetical-start
610+
AsyncDestruct,
611+
AsyncFnKindHelper,
612+
AsyncFnKindUpvars,
613+
AsyncFnOnceOutput,
614+
AsyncIterator,
615+
CallOnceFuture,
616+
CallRefFuture,
617+
Clone,
618+
Copy,
619+
Coroutine,
620+
CoroutineReturn,
621+
CoroutineYield,
622+
Destruct,
623+
DiscriminantKind,
624+
DynMetadata,
625+
FnPtrTrait,
626+
FusedIterator,
627+
Future,
628+
FutureOutput,
629+
Iterator,
630+
Metadata,
631+
Option,
632+
PointeeTrait,
633+
PointerLike,
634+
Poll,
635+
Sized,
636+
TransmuteTrait,
637+
Tuple,
638+
Unpin,
639+
Unsize,
640+
// tidy-alphabetical-end
641+
}
642+
622643
impl<'tcx> rustc_type_ir::inherent::DefId<TyCtxt<'tcx>> for DefId {
623644
fn as_local(self) -> Option<LocalDefId> {
624645
self.as_local()

‎compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs

Lines changed: 47 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -382,46 +382,58 @@ where
382382
G::consider_auto_trait_candidate(self, goal)
383383
} else if cx.trait_is_alias(trait_def_id) {
384384
G::consider_trait_alias_candidate(self, goal)
385-
} else if cx.is_lang_item(trait_def_id, TraitSolverLangItem::Sized) {
386-
G::consider_builtin_sized_candidate(self, goal)
387-
} else if cx.is_lang_item(trait_def_id, TraitSolverLangItem::Copy)
388-
|| cx.is_lang_item(trait_def_id, TraitSolverLangItem::Clone)
389-
{
390-
G::consider_builtin_copy_clone_candidate(self, goal)
391-
} else if cx.is_lang_item(trait_def_id, TraitSolverLangItem::PointerLike) {
392-
G::consider_builtin_pointer_like_candidate(self, goal)
393-
} else if cx.is_lang_item(trait_def_id, TraitSolverLangItem::FnPtrTrait) {
394-
G::consider_builtin_fn_ptr_trait_candidate(self, goal)
395385
} else if let Some(kind) = self.cx().fn_trait_kind_from_def_id(trait_def_id) {
396386
G::consider_builtin_fn_trait_candidates(self, goal, kind)
397387
} else if let Some(kind) = self.cx().async_fn_trait_kind_from_def_id(trait_def_id) {
398388
G::consider_builtin_async_fn_trait_candidates(self, goal, kind)
399-
} else if cx.is_lang_item(trait_def_id, TraitSolverLangItem::AsyncFnKindHelper) {
400-
G::consider_builtin_async_fn_kind_helper_candidate(self, goal)
401-
} else if cx.is_lang_item(trait_def_id, TraitSolverLangItem::Tuple) {
402-
G::consider_builtin_tuple_candidate(self, goal)
403-
} else if cx.is_lang_item(trait_def_id, TraitSolverLangItem::PointeeTrait) {
404-
G::consider_builtin_pointee_candidate(self, goal)
405-
} else if cx.is_lang_item(trait_def_id, TraitSolverLangItem::Future) {
406-
G::consider_builtin_future_candidate(self, goal)
407-
} else if cx.is_lang_item(trait_def_id, TraitSolverLangItem::Iterator) {
408-
G::consider_builtin_iterator_candidate(self, goal)
409-
} else if cx.is_lang_item(trait_def_id, TraitSolverLangItem::FusedIterator) {
410-
G::consider_builtin_fused_iterator_candidate(self, goal)
411-
} else if cx.is_lang_item(trait_def_id, TraitSolverLangItem::AsyncIterator) {
412-
G::consider_builtin_async_iterator_candidate(self, goal)
413-
} else if cx.is_lang_item(trait_def_id, TraitSolverLangItem::Coroutine) {
414-
G::consider_builtin_coroutine_candidate(self, goal)
415-
} else if cx.is_lang_item(trait_def_id, TraitSolverLangItem::DiscriminantKind) {
416-
G::consider_builtin_discriminant_kind_candidate(self, goal)
417-
} else if cx.is_lang_item(trait_def_id, TraitSolverLangItem::AsyncDestruct) {
418-
G::consider_builtin_async_destruct_candidate(self, goal)
419-
} else if cx.is_lang_item(trait_def_id, TraitSolverLangItem::Destruct) {
420-
G::consider_builtin_destruct_candidate(self, goal)
421-
} else if cx.is_lang_item(trait_def_id, TraitSolverLangItem::TransmuteTrait) {
422-
G::consider_builtin_transmute_candidate(self, goal)
423389
} else {
424-
Err(NoSolution)
390+
match cx.as_lang_item(trait_def_id) {
391+
Some(TraitSolverLangItem::Sized) => G::consider_builtin_sized_candidate(self, goal),
392+
Some(TraitSolverLangItem::Copy | TraitSolverLangItem::Clone) => {
393+
G::consider_builtin_copy_clone_candidate(self, goal)
394+
}
395+
Some(TraitSolverLangItem::PointerLike) => {
396+
G::consider_builtin_pointer_like_candidate(self, goal)
397+
}
398+
Some(TraitSolverLangItem::FnPtrTrait) => {
399+
G::consider_builtin_fn_ptr_trait_candidate(self, goal)
400+
}
401+
Some(TraitSolverLangItem::AsyncFnKindHelper) => {
402+
G::consider_builtin_async_fn_kind_helper_candidate(self, goal)
403+
}
404+
Some(TraitSolverLangItem::Tuple) => G::consider_builtin_tuple_candidate(self, goal),
405+
Some(TraitSolverLangItem::PointeeTrait) => {
406+
G::consider_builtin_pointee_candidate(self, goal)
407+
}
408+
Some(TraitSolverLangItem::Future) => {
409+
G::consider_builtin_future_candidate(self, goal)
410+
}
411+
Some(TraitSolverLangItem::Iterator) => {
412+
G::consider_builtin_iterator_candidate(self, goal)
413+
}
414+
Some(TraitSolverLangItem::FusedIterator) => {
415+
G::consider_builtin_fused_iterator_candidate(self, goal)
416+
}
417+
Some(TraitSolverLangItem::AsyncIterator) => {
418+
G::consider_builtin_async_iterator_candidate(self, goal)
419+
}
420+
Some(TraitSolverLangItem::Coroutine) => {
421+
G::consider_builtin_coroutine_candidate(self, goal)
422+
}
423+
Some(TraitSolverLangItem::DiscriminantKind) => {
424+
G::consider_builtin_discriminant_kind_candidate(self, goal)
425+
}
426+
Some(TraitSolverLangItem::AsyncDestruct) => {
427+
G::consider_builtin_async_destruct_candidate(self, goal)
428+
}
429+
Some(TraitSolverLangItem::Destruct) => {
430+
G::consider_builtin_destruct_candidate(self, goal)
431+
}
432+
Some(TraitSolverLangItem::TransmuteTrait) => {
433+
G::consider_builtin_transmute_candidate(self, goal)
434+
}
435+
_ => Err(NoSolution),
436+
}
425437
};
426438

427439
candidates.extend(result);

‎compiler/rustc_type_ir/src/interner.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,8 @@ pub trait Interner:
220220

221221
fn is_lang_item(self, def_id: Self::DefId, lang_item: TraitSolverLangItem) -> bool;
222222

223+
fn as_lang_item(self, def_id: Self::DefId) -> Option<TraitSolverLangItem>;
224+
223225
fn associated_type_def_ids(self, def_id: Self::DefId) -> impl IntoIterator<Item = Self::DefId>;
224226

225227
// FIXME: move `fast_reject` into `rustc_type_ir`.

0 commit comments

Comments
 (0)