Generalized BasicBlocks in BuilderMethods trait

Author: denismerigoux

src/librustc_codegen_llvm/base.rs

@@ -76,6 +76,7 @@ use rustc_data_structures::small_c_str::SmallCStr;
 use rustc_data_structures::sync::Lrc;
 
 use traits::BuilderMethods;
+use llvm::BasicBlock;
 
 use std::any::Any;
 use std::ffi::CString;
@@ -392,7 +393,7 @@ pub fn call_assume(bx: &Builder<'_, 'll, '_, &'ll Value>, val: &'ll Value) {
 
 pub fn from_immediate<'a, 'll: 'a, 'tcx: 'll,
     Value : ?Sized,
-    Builder: BuilderMethods<'a, 'll, 'tcx, Value>>(
+    Builder: BuilderMethods<'a, 'll, 'tcx, Value, BasicBlock>>(
     bx: &Builder,
     val: &'ll Value
 ) -> &'ll Value where Value : ValueTrait {
@@ -427,7 +428,7 @@ pub fn to_immediate_scalar(
 
 pub fn call_memcpy<'a, 'll: 'a, 'tcx: 'll,
     Value : ?Sized,
-    Builder: BuilderMethods<'a, 'll, 'tcx, Value>>(
+    Builder: BuilderMethods<'a, 'll, 'tcx, Value, BasicBlock>>(
     bx: &Builder,
     dst: &'ll Value,
     src: &'ll Value,
@@ -456,7 +457,7 @@ pub fn call_memcpy<'a, 'll: 'a, 'tcx: 'll,
 
 pub fn memcpy_ty<'a, 'll: 'a, 'tcx: 'll,
     Value : ?Sized,
-    Builder: BuilderMethods<'a, 'll, 'tcx, Value>>(
+    Builder: BuilderMethods<'a, 'll, 'tcx, Value, BasicBlock>>(
     bx: &Builder,
     dst: &'ll Value,
     src: &'ll Value,

src/librustc_codegen_llvm/builder.rs

@@ -55,7 +55,8 @@ bitflags! {
     }
 }
 
-impl BuilderMethods<'a, 'll, 'tcx, Value> for Builder<'a, 'll, 'tcx, &'ll Value> {
+impl BuilderMethods<'a, 'll, 'tcx, Value, BasicBlock>
+    for Builder<'a, 'll, 'tcx, &'ll Value> {
     fn new_block<'b>(
         cx: &'a CodegenCx<'ll, 'tcx, &'ll Value>,
         llfn: &'ll Value,

src/librustc_codegen_llvm/mir/operand.rs

@@ -23,6 +23,7 @@ use type_::Type;
 use glue;
 
 use traits::BuilderMethods;
+use llvm::BasicBlock;
 
 use std::fmt;
 
@@ -281,7 +282,8 @@ impl OperandValue<&'ll Value> {
 
 impl<'a, 'll: 'a, 'tcx: 'll, Value : ?Sized> OperandValue<&'ll Value> where
     Value : ValueTrait,
-    Builder<'a, 'll, 'tcx, &'ll Value>: BuilderMethods<'a, 'll, 'tcx, Value>
+    Builder<'a, 'll, 'tcx, &'ll Value>:
+        BuilderMethods<'a, 'll, 'tcx, Value, BasicBlock>
 {
     pub fn nontemporal_store(
         self,
@@ -291,7 +293,7 @@ impl<'a, 'll: 'a, 'tcx: 'll, Value : ?Sized> OperandValue<&'ll Value> where
         self.store_with_flags(bx, dest, MemFlags::NONTEMPORAL);
     }
 
-    fn store_with_flags<Builder: BuilderMethods<'a, 'll, 'tcx, Value>>(
+    fn store_with_flags<Builder: BuilderMethods<'a, 'll, 'tcx, Value, BasicBlock>>(
         self,
         bx: &Builder,
         dest: PlaceRef<'tcx, &'ll Value>,

src/librustc_codegen_llvm/traits.rs

@@ -10,7 +10,7 @@
 
 use llvm::{AtomicRmwBinOp, AtomicOrdering, SynchronizationScope, AsmDialect};
 use llvm::{IntPredicate, RealPredicate, OperandBundleDef};
-use llvm::{self, BasicBlock};
+use llvm;
 use common::*;
 use type_::Type;
 use libc::c_char;
@@ -23,7 +23,11 @@ use std::borrow::Cow;
 use std::ops::Range;
 
 
-pub trait BuilderMethods<'a, 'll :'a, 'tcx: 'll, Value : ?Sized> {
+pub trait BuilderMethods<'a, 'll :'a, 'tcx: 'll,
+    Value : ?Sized,
+    BasicBlock: ?Sized
+    > {
+
     fn new_block<'b>(
         cx: &'a CodegenCx<'ll, 'tcx, &'ll Value>,
         llfn: &'ll Value,