Skip to content

Commit

Permalink
auto merge of #8223 : davidhalperin/rust/master, r=Aatch
Browse files Browse the repository at this point in the history
Closes #7907

This is my first pull request so let me know if I've done anything wrong.  I tried to pick off a nice easy one.
  • Loading branch information
bors committed Aug 3, 2013
2 parents 800dbff + fe8ad14 commit b5d77d2
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 3 deletions.
9 changes: 6 additions & 3 deletions src/librustc/middle/typeck/coherence.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand Down Expand Up @@ -396,8 +396,11 @@ impl CoherenceChecker {

if self.polytypes_unify(polytype_a, polytype_b) {
let session = self.crate_context.tcx.sess;
session.span_err(self.span_of_impl(implementation_b),
"conflicting implementations for a trait");
session.span_err(
self.span_of_impl(implementation_b),
fmt!("conflicting implementations for trait `%s`",
ty::item_path_str(self.crate_context.tcx,
trait_def_id)));
session.span_note(self.span_of_impl(implementation_a),
"note conflicting implementation here");
}
Expand Down
24 changes: 24 additions & 0 deletions src/test/compile-fail/conflicting-implementations.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// error-pattern: conflicting implementations for trait `Foo`
trait Foo {
}

impl Foo for int {

}

impl<A> Foo for A {

}

fn main() {
}

0 comments on commit b5d77d2

Please sign in to comment.