Suppress errors from caller site

Author: long-long-float

compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs

@@ -2839,22 +2839,13 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
                     let msg =
                         format!("{} and panic if the converted value doesn't fit", msg.clone());
                     let mut suggestion = sugg.clone();
-                    if !expr.span.in_derive_expansion() {
-                        suggestion.push((
-                            expr.span.shrink_to_hi(),
-                            format!("{close_paren}.try_into().unwrap()"),
-                        ));
-                    }
+                    suggestion.push((
+                        expr.span.shrink_to_hi(),
+                        format!("{close_paren}.try_into().unwrap()"),
+                    ));
                     (msg, suggestion)
                 };
-
-                if !suggestion.is_empty() {
-                    err.multipart_suggestion_verbose(
-                        msg,
-                        suggestion,
-                        Applicability::MachineApplicable,
-                    );
-                }
+                err.multipart_suggestion_verbose(msg, suggestion, Applicability::MachineApplicable);
             };
 
         let suggest_to_change_suffix_or_into =
@@ -2905,8 +2896,12 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
                     (None, _) | (_, None) => (true, true),
                     _ => (false, false),
                 };
-                suggest_to_change_suffix_or_into(err, f2e_is_fallible, e2f_is_fallible);
-                true
+                if !expr.span.in_derive_expansion() {
+                    suggest_to_change_suffix_or_into(err, f2e_is_fallible, e2f_is_fallible);
+                    true
+                } else {
+                    false
+                }
             }
             (ty::Uint(exp), ty::Uint(found)) => {
                 let (f2e_is_fallible, e2f_is_fallible) = match (exp.bit_width(), found.bit_width())
@@ -2918,8 +2913,12 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
                     (None, _) | (_, None) => (true, true),
                     _ => (false, false),
                 };
-                suggest_to_change_suffix_or_into(err, f2e_is_fallible, e2f_is_fallible);
-                true
+                if !expr.span.in_derive_expansion() {
+                    suggest_to_change_suffix_or_into(err, f2e_is_fallible, e2f_is_fallible);
+                    true
+                } else {
+                    false
+                }
             }
             (&ty::Int(exp), &ty::Uint(found)) => {
                 let (f2e_is_fallible, e2f_is_fallible) = match (exp.bit_width(), found.bit_width())