Skip to content

Commit

Permalink
Rollup merge of #112089 - Kobzol:bootstrap-warnings, r=jyn514
Browse files Browse the repository at this point in the history
Add `--warnings warn` flag to `x.py`

So that bootstrap itself can be built with warnings not being treated as errors.

Fixes: #76805

r? ``@jyn514``
  • Loading branch information
matthiaskrgr authored May 31, 2023
2 parents 2e64710 + 023e6c4 commit a283d55
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions src/bootstrap/bootstrap.py
Original file line number Diff line number Diff line change
Expand Up @@ -835,7 +835,7 @@ def bootstrap_binary(self):
"""
return os.path.join(self.build_dir, "bootstrap", "debug", "bootstrap")

def build_bootstrap(self, color, verbose_count):
def build_bootstrap(self, color, warnings, verbose_count):
"""Build bootstrap"""
env = os.environ.copy()
if "GITHUB_ACTIONS" in env:
Expand Down Expand Up @@ -894,7 +894,11 @@ def build_bootstrap(self, color, verbose_count):
if target_linker is not None:
env["RUSTFLAGS"] += " -C linker=" + target_linker
env["RUSTFLAGS"] += " -Wrust_2018_idioms -Wunused_lifetimes"
if self.get_toml("deny-warnings", "rust") != "false":
if warnings == "default":
deny_warnings = self.get_toml("deny-warnings", "rust") != "false"
else:
deny_warnings = warnings == "deny"
if deny_warnings:
env["RUSTFLAGS"] += " -Dwarnings"

env["PATH"] = os.path.join(self.bin_root(), "bin") + \
Expand Down Expand Up @@ -987,6 +991,7 @@ def parse_args():
parser.add_argument('--color', choices=['always', 'never', 'auto'])
parser.add_argument('--clean', action='store_true')
parser.add_argument('--json-output', action='store_true')
parser.add_argument('--warnings', choices=['deny', 'warn', 'default'], default='default')
parser.add_argument('-v', '--verbose', action='count', default=0)

return parser.parse_known_args(sys.argv)[0]
Expand Down Expand Up @@ -1052,7 +1057,7 @@ def bootstrap(args):
# Fetch/build the bootstrap
build.download_toolchain()
sys.stdout.flush()
build.build_bootstrap(args.color, verbose_count)
build.build_bootstrap(args.color, args.warnings, verbose_count)
sys.stdout.flush()

# Run the bootstrap
Expand Down

0 comments on commit a283d55

Please sign in to comment.