address review

Author: LorrensP-2158466

tests/ui/imports/auxiliary/same-res-ambigious-extern-fail.rs

@@ -6,10 +6,9 @@ macro_rules! globbing{
     }
 }
 
-#[allow(unused_imports)]
-#[macro_use]
+#[macro_use] // this imports the `RustEmbed` macro with `pub(crate)` visibility
 extern crate same_res_ambigious_extern_macro;
-globbing! {}
+globbing! {} // this imports the same `RustEmbed` macro with `pub` visibility
 
 pub trait RustEmbed {}
 

tests/ui/imports/auxiliary/same-res-ambigious-extern.rs

@@ -1,8 +1,8 @@
 //@ proc-macro: same-res-ambigious-extern-macro.rs
 
-#[allow(unused_imports)]
-#[macro_use]
+#[macro_use] // this imports the `RustEmbed` macro with `pub(crate)` visibility
 extern crate same_res_ambigious_extern_macro;
+// this imports the same `RustEmbed` macro with `pub` visibility
 pub use same_res_ambigious_extern_macro::*;
 
 pub trait RustEmbed {}

tests/ui/imports/same-res-ambigious.rs

@@ -1,14 +1,10 @@
-//@ revisions: nightly-fail nightly-pass
-//@[nightly-pass] check-pass
-//@[nightly-pass] aux-crate: ambigious_extern=same-res-ambigious-extern.rs
+//@ revisions: nightly-fail pass
+//@[pass] check-pass
+//@[pass] aux-crate: ambigious_extern=same-res-ambigious-extern.rs
 //@[nightly-fail] aux-crate: ambigious_extern=same-res-ambigious-extern-fail.rs
 // see https://github.com/rust-lang/rust/pull/147196
 
-extern crate ambigious_extern;
-use ambigious_extern::Embed;
-
-
-#[derive(Embed)] //[nightly-fail]~ Error: cannot find derive macro `Embed` in this scope
+#[derive(ambigious_extern::Embed)] //[nightly-fail]~ Error: cannot find derive macro `Embed` in this scope
 struct Foo{}
 
 fn main(){}