Skip to content

Commit

Permalink
Rollup merge of #89487 - FabianWolff:issue-89396, r=petrochenkov
Browse files Browse the repository at this point in the history
Try to recover from a `=>` -> `=` or `->` typo in a match arm

Fixes #89396.
  • Loading branch information
workingjubilee authored Oct 5, 2021
2 parents 25cc28e + 079c075 commit 90e96f9
Show file tree
Hide file tree
Showing 5 changed files with 71 additions and 1 deletion.
1 change: 1 addition & 0 deletions compiler/rustc_ast/src/token.rs
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ impl TokenKind {
match *self {
Comma => Some(vec![Dot, Lt, Semi]),
Semi => Some(vec![Colon, Comma]),
FatArrow => Some(vec![Eq, RArrow]),
_ => None,
}
}
Expand Down
19 changes: 18 additions & 1 deletion compiler/rustc_parse/src/parser/expr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2322,7 +2322,24 @@ impl<'a> Parser<'a> {
None
};
let arrow_span = this.token.span;
this.expect(&token::FatArrow)?;
if let Err(mut err) = this.expect(&token::FatArrow) {
// We might have a `=>` -> `=` or `->` typo (issue #89396).
if TokenKind::FatArrow
.similar_tokens()
.map_or(false, |similar_tokens| similar_tokens.contains(&this.token.kind))
{
err.span_suggestion(
this.token.span,
"try using a fat arrow here",
"=>".to_string(),
Applicability::MaybeIncorrect,
);
err.emit();
this.bump();
} else {
return Err(err);
}
}
let arm_start_span = this.token.span;

let expr = this.parse_expr_res(Restrictions::STMT_EXPR, None).map_err(|mut err| {
Expand Down
16 changes: 16 additions & 0 deletions src/test/ui/parser/issue-89396.fixed
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// Regression test for issue #89396: Try to recover from a
// `=>` -> `=` or `->` typo in a match arm.

// run-rustfix

fn main() {
let opt = Some(42);
let _ = match opt {
Some(_) => true,
//~^ ERROR: expected one of
//~| HELP: try using a fat arrow here
None => false,
//~^ ERROR: expected one of
//~| HELP: try using a fat arrow here
};
}
16 changes: 16 additions & 0 deletions src/test/ui/parser/issue-89396.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// Regression test for issue #89396: Try to recover from a
// `=>` -> `=` or `->` typo in a match arm.

// run-rustfix

fn main() {
let opt = Some(42);
let _ = match opt {
Some(_) = true,
//~^ ERROR: expected one of
//~| HELP: try using a fat arrow here
None -> false,
//~^ ERROR: expected one of
//~| HELP: try using a fat arrow here
};
}
20 changes: 20 additions & 0 deletions src/test/ui/parser/issue-89396.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
error: expected one of `=>`, `if`, or `|`, found `=`
--> $DIR/issue-89396.rs:9:17
|
LL | Some(_) = true,
| ^
| |
| expected one of `=>`, `if`, or `|`
| help: try using a fat arrow here: `=>`

error: expected one of `=>`, `@`, `if`, or `|`, found `->`
--> $DIR/issue-89396.rs:12:14
|
LL | None -> false,
| ^^
| |
| expected one of `=>`, `@`, `if`, or `|`
| help: try using a fat arrow here: `=>`

error: aborting due to 2 previous errors

0 comments on commit 90e96f9

Please sign in to comment.