From 78baf421aa31ccd04243ee6b6e804999f835f880 Mon Sep 17 00:00:00 2001 From: LeSeulArtichaut Date: Wed, 24 Jun 2020 15:33:08 +0200 Subject: [PATCH 1/3] Add procedure for prioritization notifications on Zulip --- triagebot.toml | 76 +++++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 69 insertions(+), 7 deletions(-) diff --git a/triagebot.toml b/triagebot.toml index 5361a618d4e85..a939a3e8106e2 100644 --- a/triagebot.toml +++ b/triagebot.toml @@ -78,42 +78,104 @@ exclude_labels = [ [notify-zulip."I-prioritize"] zulip_stream = 227806 # #t-compiler/wg-prioritization topic = "I-prioritize #{number} {title}" -message_on_add = "@*WG-prioritization* issue #{number} has been requested for prioritization." +message_on_add = """\ +@*WG-prioritization* issue #{number} has been requested for prioritization. + +# [Procedure](https://hackmd.io/WJ0G17DHTHGgv0OW9I2PxA?view#Unprioritized-I-prioritize) +- Priority? +- Regression? +- Notify people/groups? +- Needs `I-nominated`? +""" message_on_remove = "Issue #{number}'s prioritization request has been removed." [notify-zulip."I-nominated"] required_labels = ["T-compiler"] zulip_stream = 227806 # #t-compiler/wg-prioritization topic = "I-prioritize #{number} {title}" -message_on_add = "@*WG-prioritization* #{number} has been nominated for discussion in `T-compiler` meeting." +message_on_add = """\ +#{number} has been nominated for discussion in `T-compiler` meeting. + +# [Procedure](https://hackmd.io/WJ0G17DHTHGgv0OW9I2PxA?view#I-nominated) +- Already discussed? +- Worth the meeting time? +- Add agenda entry: + - Why nominated? + - Assignee? + - Issue? PR? What's the status? + - Summary and important details? +""" message_on_remove = "#{number}'s nomination has been removed." [notify-zulip."beta-nominated"] zulip_stream = 227806 # #t-compiler/wg-prioritization topic = "Backport #{number} {title}" -message_on_add = "@*WG-prioritization* PR #{number} has been requested for beta backport." +message_on_add = """\ +PR #{number} has been requested for beta backport. + +# [Procedure](https://hackmd.io/WJ0G17DHTHGgv0OW9I2PxA?view#StableBeta-nominations) +Prepare agenda entry: +- Why nominated? +- Author, assignee? +- Important details? +""" message_on_remove = "PR #{number}'s beta backport request has been removed." [notify-zulip."stable-nominated"] zulip_stream = 227806 # #t-compiler/wg-prioritization topic = "Backport #{number} {title}" -message_on_add = "@*WG-prioritization* PR #{number} has been requested for stable backport." +message_on_add = """\ +PR #{number} has been requested for stable backport. + +# [Procedure](https://hackmd.io/WJ0G17DHTHGgv0OW9I2PxA?view#StableBeta-nominations) +Prepare agenda entry: +- Why nominated? +- Author, assignee? +- Important details? +""" message_on_remove = "PR #{number}'s stable backport request has been removed." [notify-zulip."S-waiting-on-team"] required_labels = ["T-compiler"] zulip_stream = 227806 # #t-compiler/wg-prioritization topic = "S-waiting-on-team #{number} {title}" -message_on_add = "@*WG-prioritization* PR #{number} is waiting on `T-compiler`." +message_on_add = """\ +PR #{number} is waiting on `T-compiler`. + +# [Procedure](https://hackmd.io/WJ0G17DHTHGgv0OW9I2PxA?view#PR%E2%80%99s-waiting-on-team) +- Prepare agenda entry: + - What is it waiting for? + - Important details? +- Could be resolved quickly? Tag `I-nominated`. +""" message_on_remove = "PR #{number}'s is no longer waiting on `T-compiler`." [notify-zulip."P-critical"] zulip_stream = 227806 # #t-compiler/wg-prioritization topic = "P-critical #{number} {title}" -message_on_add = "@*WG-prioritization* issue #{number} has been assigned `P-critical`." +message_on_add = """\ +Issue #{number} has been assigned `P-critical`. + +# [Procedure](https://hackmd.io/WJ0G17DHTHGgv0OW9I2PxA?view#P-critical-and-Unassigned-P-high-regressions) +- Notify people/groups? +- Assign if possible? +- Add to agenda: + - Assignee? + - Summary and important details? +- Other actions to move forward? +""" [notify-zulip."P-high"] required_labels = ["regression-from-stable-to-[bn]*"] # only nightly and beta regressions zulip_stream = 227806 # #t-compiler/wg-prioritization topic = "P-high regression #{number} {title}" -message_on_add = "@*WG-prioritization* issue #{number} has been assigned `P-high` and is a regression." +message_on_add = """\ +Issue #{number} has been assigned `P-high` and is a regression. + +# [Procedure](https://hackmd.io/WJ0G17DHTHGgv0OW9I2PxA?view#P-critical-and-Unassigned-P-high-regressions) +Is issue assigned? If not: +- Try to find an assignee? +- Otherwise add to agenda: + - Mark as unassigned. + - Summary and important details? +""" From 5881b52d9af78fad44320bfe1a8be9369160205c Mon Sep 17 00:00:00 2001 From: Santiago Pastorino Date: Wed, 24 Jun 2020 12:32:44 -0300 Subject: [PATCH 2/3] Change wg-prioritization stream --- triagebot.toml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/triagebot.toml b/triagebot.toml index a939a3e8106e2..6b57b6340049a 100644 --- a/triagebot.toml +++ b/triagebot.toml @@ -76,7 +76,7 @@ exclude_labels = [ ] [notify-zulip."I-prioritize"] -zulip_stream = 227806 # #t-compiler/wg-prioritization +zulip_stream = 245100 # #t-compiler/wg-prioritization/alerts topic = "I-prioritize #{number} {title}" message_on_add = """\ @*WG-prioritization* issue #{number} has been requested for prioritization. @@ -91,7 +91,7 @@ message_on_remove = "Issue #{number}'s prioritization request has been removed." [notify-zulip."I-nominated"] required_labels = ["T-compiler"] -zulip_stream = 227806 # #t-compiler/wg-prioritization +zulip_stream = 245100 # #t-compiler/wg-prioritization/alerts topic = "I-prioritize #{number} {title}" message_on_add = """\ #{number} has been nominated for discussion in `T-compiler` meeting. @@ -108,7 +108,7 @@ message_on_add = """\ message_on_remove = "#{number}'s nomination has been removed." [notify-zulip."beta-nominated"] -zulip_stream = 227806 # #t-compiler/wg-prioritization +zulip_stream = 245100 # #t-compiler/wg-prioritization/alerts topic = "Backport #{number} {title}" message_on_add = """\ PR #{number} has been requested for beta backport. @@ -122,7 +122,7 @@ Prepare agenda entry: message_on_remove = "PR #{number}'s beta backport request has been removed." [notify-zulip."stable-nominated"] -zulip_stream = 227806 # #t-compiler/wg-prioritization +zulip_stream = 245100 # #t-compiler/wg-prioritization/alerts topic = "Backport #{number} {title}" message_on_add = """\ PR #{number} has been requested for stable backport. @@ -137,7 +137,7 @@ message_on_remove = "PR #{number}'s stable backport request has been removed." [notify-zulip."S-waiting-on-team"] required_labels = ["T-compiler"] -zulip_stream = 227806 # #t-compiler/wg-prioritization +zulip_stream = 245100 # #t-compiler/wg-prioritization/alerts topic = "S-waiting-on-team #{number} {title}" message_on_add = """\ PR #{number} is waiting on `T-compiler`. @@ -151,7 +151,7 @@ PR #{number} is waiting on `T-compiler`. message_on_remove = "PR #{number}'s is no longer waiting on `T-compiler`." [notify-zulip."P-critical"] -zulip_stream = 227806 # #t-compiler/wg-prioritization +zulip_stream = 245100 # #t-compiler/wg-prioritization/alerts topic = "P-critical #{number} {title}" message_on_add = """\ Issue #{number} has been assigned `P-critical`. @@ -167,7 +167,7 @@ Issue #{number} has been assigned `P-critical`. [notify-zulip."P-high"] required_labels = ["regression-from-stable-to-[bn]*"] # only nightly and beta regressions -zulip_stream = 227806 # #t-compiler/wg-prioritization +zulip_stream = 245100 # #t-compiler/wg-prioritization/alerts topic = "P-high regression #{number} {title}" message_on_add = """\ Issue #{number} has been assigned `P-high` and is a regression. From ff068762a0a1a7bc9559101ba74d16862b7028b6 Mon Sep 17 00:00:00 2001 From: Santiago Pastorino Date: Wed, 24 Jun 2020 12:36:17 -0300 Subject: [PATCH 3/3] Alert @WG-prioritization/alerts instead of @WG-prioritization --- triagebot.toml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/triagebot.toml b/triagebot.toml index 6b57b6340049a..73ca7abfed363 100644 --- a/triagebot.toml +++ b/triagebot.toml @@ -79,7 +79,7 @@ exclude_labels = [ zulip_stream = 245100 # #t-compiler/wg-prioritization/alerts topic = "I-prioritize #{number} {title}" message_on_add = """\ -@*WG-prioritization* issue #{number} has been requested for prioritization. +@*WG-prioritization/alerts* issue #{number} has been requested for prioritization. # [Procedure](https://hackmd.io/WJ0G17DHTHGgv0OW9I2PxA?view#Unprioritized-I-prioritize) - Priority? @@ -94,7 +94,7 @@ required_labels = ["T-compiler"] zulip_stream = 245100 # #t-compiler/wg-prioritization/alerts topic = "I-prioritize #{number} {title}" message_on_add = """\ -#{number} has been nominated for discussion in `T-compiler` meeting. +@*WG-prioritization/alerts* #{number} has been nominated for discussion in `T-compiler` meeting. # [Procedure](https://hackmd.io/WJ0G17DHTHGgv0OW9I2PxA?view#I-nominated) - Already discussed? @@ -111,7 +111,7 @@ message_on_remove = "#{number}'s nomination has been removed." zulip_stream = 245100 # #t-compiler/wg-prioritization/alerts topic = "Backport #{number} {title}" message_on_add = """\ -PR #{number} has been requested for beta backport. +@*WG-prioritization/alerts* PR #{number} has been requested for beta backport. # [Procedure](https://hackmd.io/WJ0G17DHTHGgv0OW9I2PxA?view#StableBeta-nominations) Prepare agenda entry: @@ -125,7 +125,7 @@ message_on_remove = "PR #{number}'s beta backport request has been removed." zulip_stream = 245100 # #t-compiler/wg-prioritization/alerts topic = "Backport #{number} {title}" message_on_add = """\ -PR #{number} has been requested for stable backport. +@*WG-prioritization/alerts* PR #{number} has been requested for stable backport. # [Procedure](https://hackmd.io/WJ0G17DHTHGgv0OW9I2PxA?view#StableBeta-nominations) Prepare agenda entry: @@ -140,7 +140,7 @@ required_labels = ["T-compiler"] zulip_stream = 245100 # #t-compiler/wg-prioritization/alerts topic = "S-waiting-on-team #{number} {title}" message_on_add = """\ -PR #{number} is waiting on `T-compiler`. +@*WG-prioritization/alerts* PR #{number} is waiting on `T-compiler`. # [Procedure](https://hackmd.io/WJ0G17DHTHGgv0OW9I2PxA?view#PR%E2%80%99s-waiting-on-team) - Prepare agenda entry: @@ -154,7 +154,7 @@ message_on_remove = "PR #{number}'s is no longer waiting on `T-compiler`." zulip_stream = 245100 # #t-compiler/wg-prioritization/alerts topic = "P-critical #{number} {title}" message_on_add = """\ -Issue #{number} has been assigned `P-critical`. +@*WG-prioritization/alerts* issue #{number} has been assigned `P-critical`. # [Procedure](https://hackmd.io/WJ0G17DHTHGgv0OW9I2PxA?view#P-critical-and-Unassigned-P-high-regressions) - Notify people/groups? @@ -170,7 +170,7 @@ required_labels = ["regression-from-stable-to-[bn]*"] # only nightly and beta re zulip_stream = 245100 # #t-compiler/wg-prioritization/alerts topic = "P-high regression #{number} {title}" message_on_add = """\ -Issue #{number} has been assigned `P-high` and is a regression. +@*WG-prioritization/alerts* issue #{number} has been assigned `P-high` and is a regression. # [Procedure](https://hackmd.io/WJ0G17DHTHGgv0OW9I2PxA?view#P-critical-and-Unassigned-P-high-regressions) Is issue assigned? If not: