-
Notifications
You must be signed in to change notification settings - Fork 12.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rollup merge of #91111 - cjgillot:hir-no-lower-attrs, r=michaelwoerister
Do not visit attributes in `ItemLowerer`. By default, AST visitors visit expressions that appear in key-value attributes. Those expressions should not be lowered to HIR, as they do not correspond to actually compiled code. Since an attribute cannot produce meaningful HIR, just skip them altogether. Fixes #81886 Fixes #90873 r? `@michaelwoerister`
- Loading branch information
Showing
6 changed files
with
69 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
#![u=||{static d=||1;}] | ||
//~^ unexpected token | ||
//~| cannot find attribute `u` in this scope | ||
//~| `main` function not found in crate `issue_90873` | ||
//~| missing type for `static` item | ||
|
||
#![a={impl std::ops::Neg for i8 {}}] | ||
//~^ ERROR unexpected token | ||
//~| ERROR cannot find attribute `a` in this scope |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
error: unexpected token: `|| | ||
{ | ||
static d: _ = || 1; | ||
}` | ||
--> $DIR/issue-90873.rs:1:6 | ||
| | ||
LL | #![u=||{static d=||1;}] | ||
| ^^^^^^^^^^^^^^^^^ | ||
|
||
error: unexpected token: `{ | ||
impl std::ops::Neg for i8 { } | ||
}` | ||
--> $DIR/issue-90873.rs:7:6 | ||
| | ||
LL | #![a={impl std::ops::Neg for i8 {}}] | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
error: cannot find attribute `u` in this scope | ||
--> $DIR/issue-90873.rs:1:4 | ||
| | ||
LL | #![u=||{static d=||1;}] | ||
| ^ | ||
|
||
error: cannot find attribute `a` in this scope | ||
--> $DIR/issue-90873.rs:7:4 | ||
| | ||
LL | #![a={impl std::ops::Neg for i8 {}}] | ||
| ^ | ||
|
||
error[E0601]: `main` function not found in crate `issue_90873` | ||
--> $DIR/issue-90873.rs:1:1 | ||
| | ||
LL | / #![u=||{static d=||1;}] | ||
LL | | | ||
LL | | | ||
LL | | | ||
LL | | | ||
LL | | | ||
LL | | #![a={impl std::ops::Neg for i8 {}}] | ||
| |____________________________________^ consider adding a `main` function to `$DIR/issue-90873.rs` | ||
|
||
error: missing type for `static` item | ||
--> $DIR/issue-90873.rs:1:16 | ||
| | ||
LL | #![u=||{static d=||1;}] | ||
| ^ help: provide a type for the item: `d: <type>` | ||
|
||
error: aborting due to 6 previous errors | ||
|
||
For more information about this error, try `rustc --explain E0601`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters