Report 1-based indices in Error's Display impl

CAD97 · web-flow · commit 4a003cc00686 · 2021-05-01T22:56:42.000-05:00
This matches every (mainstream) text editor's use of the line:column format.
diff --git a/src/tools/rust-analyzer/lib/ungrammar/src/error.rs b/src/tools/rust-analyzer/lib/ungrammar/src/error.rs
@@ -16,7 +16,8 @@ pub struct Error {
 impl fmt::Display for Error {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         if let Some(loc) = self.location {
-            write!(f, "{}:{}: ", loc.line, loc.column)?
+            // Report 1-based indices, to match text editors
+            write!(f, "{}:{}: ", loc.line + 1, loc.column + 1)?
         }
         write!(f, "{}", self.message)
     }

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,8 @@ pub struct Error {`
`16`	`16`	`impl fmt::Display for Error {`
`17`	`17`	`fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {`
`18`	`18`	`if let Some(loc) = self.location {`
`19`		`- write!(f, "{}:{}: ", loc.line, loc.column)?`
	`19`	`+ // Report 1-based indices, to match text editors`
	`20`	`+ write!(f, "{}:{}: ", loc.line + 1, loc.column + 1)?`
`20`	`21`	`}`
`21`	`22`	`write!(f, "{}", self.message)`
`22`	`23`	`}`