Use serde_json::to_writer for JsonEmitter::emit

Avoids an unnecessary intermediate string.
rust-lang · Sep 9, 2023 · 4854e19 · 4854e19
1 parent c070a83
commit 4854e19
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/compiler/rustc_errors/src/json.rs b/compiler/rustc_errors/src/json.rs
@@ -141,11 +141,11 @@ impl JsonEmitter {
 
     fn emit(&mut self, val: EmitTyped<'_>) -> io::Result<()> {
         if self.pretty {
-            writeln!(self.dst, "{}", serde_json::to_string_pretty(&val).unwrap())
+            serde_json::to_writer_pretty(&mut *self.dst, &val)?
         } else {
-            writeln!(self.dst, "{}", serde_json::to_string(&val).unwrap())
-        }
-        .and_then(|_| self.dst.flush())
+            serde_json::to_writer(&mut *self.dst, &val)?
+        };
+        self.dst.flush()
     }
 }