Auto merge of #148751 - mati865:gnullvm-windows-host, r=<try>

Build gnullvm toolchains on Windows natively

try-job: dist-aarch64-llvm-mingw
try-job: dist-x86_64-llvm-mingw

Author: rust-bors[bot]

src/bootstrap/src/core/build_steps/dist.rs

@@ -300,7 +300,7 @@ fn runtime_dll_dist(rust_root: &Path, target: TargetSelection, builder: &Builder
         return;
     }
 
-    let (bin_path, libs_path) = get_cc_search_dirs(target, builder);
+    let (bin_path, _) = get_cc_search_dirs(target, builder);
 
     let mut rustc_dlls = vec![];
     // windows-gnu and windows-gnullvm require different runtime libs
@@ -316,15 +316,6 @@ fn runtime_dll_dist(rust_root: &Path, target: TargetSelection, builder: &Builder
     } else {
         panic!("Vendoring of runtime DLLs for `{target}` is not supported`");
     }
-    // FIXME(#144656): Remove this whole `let ...`
-    let bin_path = if target.ends_with("windows-gnullvm") && builder.host_target != target {
-        bin_path
-            .into_iter()
-            .chain(libs_path.iter().map(|path| path.with_file_name("bin")))
-            .collect()
-    } else {
-        bin_path
-    };
     let rustc_dlls = find_files(&rustc_dlls, &bin_path);
 
     // Copy runtime dlls next to rustc.exe
@@ -1824,8 +1815,7 @@ impl Step for Extended {
             cmd.run(builder);
         }
 
-        // FIXME(mati865): `gnullvm` here is temporary, remove it once it can host itself
-        if target.is_windows() && !target.contains("gnullvm") {
+        if target.is_windows() {
             let exe = tmp.join("exe");
             let _ = fs::remove_dir_all(&exe);
 
@@ -2188,7 +2178,7 @@ fn add_env(
         .env("CFG_CHANNEL", &builder.config.channel);
 
     if target.contains("windows-gnullvm") {
-        cmd.env("CFG_MINGW", "1").env("CFG_ABI", "LLVM");
+        cmd.env("CFG_MINGW", "0").env("CFG_ABI", "LLVM");
     } else if target.is_windows_gnu() {
         cmd.env("CFG_MINGW", "1").env("CFG_ABI", "GNU");
     } else {

src/ci/docker/host-x86_64/dist-aarch64-windows-gnullvm/Dockerfile

@@ -247,12 +247,6 @@ auto:
   - name: dist-s390x-linux
     <<: *job-linux-4c
 
-  - name: dist-aarch64-windows-gnullvm
-    <<: *job-linux-4c
-
-  - name: dist-x86_64-windows-gnullvm
-    <<: *job-linux-4c
-
   - name: dist-various-1
     <<: *job-linux-4c
 
@@ -689,6 +683,30 @@ auto:
       CODEGEN_BACKENDS: llvm,cranelift
     <<: *job-windows
 
+  - name: dist-aarch64-llvm-mingw
+    env:
+      SCRIPT: python x.py dist bootstrap --include-default-paths
+      RUST_CONFIGURE_ARGS: >-
+        --build=aarch64-pc-windows-gnullvm
+        --enable-full-tools
+        --enable-profiler
+        --enable-sanitizers
+      DIST_REQUIRE_ALL_TOOLS: 1
+      CODEGEN_BACKENDS: llvm,cranelift
+    <<: *job-windows-aarch64
+
+  - name: dist-x86_64-llvm-mingw
+    env:
+      SCRIPT: python x.py dist bootstrap --include-default-paths
+      RUST_CONFIGURE_ARGS: >-
+        --build=x86_64-pc-windows-gnullvm
+        --enable-full-tools
+        --enable-profiler
+        --enable-sanitizers
+      DIST_REQUIRE_ALL_TOOLS: 1
+      CODEGEN_BACKENDS: llvm,cranelift
+    <<: *job-windows
+
   - name: dist-x86_64-msvc-alt
     env:
       RUST_CONFIGURE_ARGS: --build=x86_64-pc-windows-msvc --enable-extended --enable-profiler

src/ci/docker/host-x86_64/dist-x86_64-windows-gnullvm/Dockerfile

@@ -8,22 +8,34 @@ source "$(cd "$(dirname "$0")" && pwd)/../shared.sh"
 
 MINGW_ARCHIVE_32="i686-14.1.0-release-posix-dwarf-msvcrt-rt_v12-rev0.7z"
 MINGW_ARCHIVE_64="x86_64-14.1.0-release-posix-seh-msvcrt-rt_v12-rev0.7z"
+LLVM_MINGW_ARCHIVE_AARCH64="llvm-mingw-20251104-ucrt-aarch64.zip"
+LLVM_MINGW_ARCHIVE_X86_64="llvm-mingw-20251104-ucrt-x86_64.zip"
 
 if isWindows && isKnownToBeMingwBuild; then
     case "${CI_JOB_NAME}" in
+        *aarch64-llvm*)
+            mingw_dir="clangarm64"
+            mingw_archive="${LLVM_MINGW_ARCHIVE_AARCH64}"
+            arch="aarch64"
+            # Rustup default to AArch64 MSVC which has troubles building Ring crate
+            rustup default stable-aarch64-pc-windows-gnullvm
+            ;;
+        *x86_64-llvm*)
+            mingw_dir="clang64"
+            mingw_archive="${LLVM_MINGW_ARCHIVE_X86_64}"
+            arch="x86_64"
+            ;;
         *i686*)
-            bits=32
+            mingw_dir="mingw32"
             mingw_archive="${MINGW_ARCHIVE_32}"
             ;;
         *x86_64*)
-            bits=64
+            mingw_dir="mingw64"
             mingw_archive="${MINGW_ARCHIVE_64}"
             ;;
         *aarch64*)
-            # aarch64 is a cross-compiled target. Use the x86_64
-            # mingw, since that's the host architecture.
-            bits=64
-            mingw_archive="${MINGW_ARCHIVE_64}"
+            echo "AArch64 Windows is not supported by GNU tools"
+            exit 1
             ;;
         *)
             echo "src/ci/scripts/install-mingw.sh can't detect the builder's architecture"
@@ -38,14 +50,32 @@ if isWindows && isKnownToBeMingwBuild; then
     msys2Path="c:/msys64"
     ciCommandAddPath "${msys2Path}/usr/bin"
 
-    mingw_dir="mingw${bits}"
+    case "${mingw_archive}" in
+        *.7z)
+            curl -o mingw.7z "${MIRRORS_BASE}/${mingw_archive}"
+            7z x -y mingw.7z > /dev/null
+            ;;
+        *.zip)
+            curl -o mingw.zip "${MIRRORS_BASE}/${mingw_archive}"
+            unzip -q mingw.zip
+            mv llvm-mingw-20251104-ucrt-$arch $mingw_dir
+            # Temporary workaround: https://github.com/mstorsjo/llvm-mingw/issues/493
+            mkdir -p $mingw_dir/bin
+            ln -s $arch-w64-windows-gnu.cfg $mingw_dir/bin/$arch-pc-windows-gnu.cfg
+            ;;
+        *)
+            echo "Unrecognized archive type"
+            exit 1
+            ;;
+    esac
 
-    curl -o mingw.7z "${MIRRORS_BASE}/${mingw_archive}"
-    7z x -y mingw.7z > /dev/null
     ciCommandAddPath "$(cygpath -m "$(pwd)/${mingw_dir}/bin")"
 
-    # Initialize mingw for the user.
-    # This should be done by github but isn't for some reason.
-    # (see https://github.com/actions/runner-images/issues/12600)
-    /c/msys64/usr/bin/bash -lc ' '
+    # MSYS2 is not installed on AArch64 runners
+    if [[ "${CI_JOB_NAME}" != *aarch64-llvm* ]]; then
+        # Initialize mingw for the user.
+        # This should be done by github but isn't for some reason.
+        # (see https://github.com/actions/runner-images/issues/12600)
+        /c/msys64/usr/bin/bash -lc ' '
+    fi
 fi

src/ci/docker/host-x86_64/dist-x86_64-windows-gnullvm/install-llvm-mingw.sh

@@ -38,6 +38,16 @@
             <?elseif $(env.CFG_CHANNEL)="dev" ?>
                 <?define UpgradeCode="231A9544-7E39-4A60-A069-0EB3CA4BAB2E" ?>
             <?endif ?>
+        <?elseif $(env.CFG_ABI)="LLVM" ?>
+            <?if $(env.CFG_CHANNEL)="stable" ?>
+                <?define UpgradeCode="BA2B2E96-F3E2-4DE9-8809-38C31382CC96" ?>
+            <?elseif $(env.CFG_CHANNEL)="beta" ?>
+                <?define UpgradeCode="44A2D96F-6CF2-4ED9-AE05-7CF0C3A7D0D9" ?>
+            <?elseif $(env.CFG_CHANNEL)="nightly" ?>
+                <?define UpgradeCode="FB0EEAE4-13FB-46BB-86E8-F9D00E6DA364" ?>
+            <?elseif $(env.CFG_CHANNEL)="dev" ?>
+                <?define UpgradeCode="73C94FB8-266F-48DC-A23B-B6E5DBDCF508" ?>
+            <?endif ?>
         <?endif ?>
         <?define PlatformProgramFilesFolder="ProgramFiles64Folder" ?>
     <?elseif $(sys.BUILDARCH)="x86" ?>
@@ -61,6 +71,16 @@
             <?elseif $(env.CFG_CHANNEL)="dev" ?>
                 <?define UpgradeCode="87DFC303-6492-4E9B-911E-56EAD56C5E58" ?>
             <?endif ?>
+        <?elseif $(env.CFG_ABI)="LLVM" ?>
+            <?if $(env.CFG_CHANNEL)="stable" ?>
+                <?define UpgradeCode="DB29CBDE-CDDF-4EC9-9C68-B6F00038EEDD" ?>
+            <?elseif $(env.CFG_CHANNEL)="beta" ?>
+                <?define UpgradeCode="AE1EF98B-1387-43BE-BE55-2310449D7E02" ?>
+            <?elseif $(env.CFG_CHANNEL)="nightly" ?>
+                <?define UpgradeCode="27B805BC-9C71-4198-A397-3082B1E708A7" ?>
+            <?elseif $(env.CFG_CHANNEL)="dev" ?>
+                <?define UpgradeCode="9DDD8D25-57C4-4410-AB35-A23A805AAD17" ?>
+            <?endif ?>
         <?endif ?>
         <?define PlatformProgramFilesFolder="ProgramFilesFolder" ?>
     <?else ?>