Simplify trait selector's evaluation API

Author: aravind-pg

src/librustc/traits/coherence.rs

@@ -156,9 +156,9 @@ fn overlap<'cx, 'gcx, 'tcx>(selcx: &mut SelectionContext<'cx, 'gcx, 'tcx>,
                                            recursion_depth: 0,
                                            predicate: p })
                      .chain(obligations)
-                     .find(|o| !selcx.evaluate_obligation(o));
-    // FIXME: the call to `selcx.evaluate_obligation` above should be ported
-    // to the canonical trait query form, `infcx.predicate_may_hold`, once
+                     .find(|o| !selcx.evaluate_obligation(o).may_apply());
+    // FIXME: the call to `selcx.evaluate_obligation().may_apply` above should be
+    // ported to the canonical trait query form, `infcx.predicate_may_hold`, once
     // the new system supports intercrate mode (which coherence needs).
 
     if let Some(failing_obligation) = opt_failing_obligation {

src/librustc/traits/select.rs

@@ -552,42 +552,14 @@ impl<'cx, 'gcx, 'tcx> SelectionContext<'cx, 'gcx, 'tcx> {
     // The result is "true" if the obligation *may* hold and "false" if
     // we can be sure it does not.
 
-    /// Evaluates whether the obligation `obligation` can be satisfied (by any means).
+    /// Evaluates whether the obligation `obligation` can be satisfied and returns
+    /// an `EvaluationResult`.
     pub fn evaluate_obligation(&mut self,
                                obligation: &PredicateObligation<'tcx>)
-                               -> bool
-    {
-        debug!("evaluate_obligation({:?})",
-               obligation);
-
-        self.probe(|this, _| {
-            this.evaluate_predicate_recursively(TraitObligationStackList::empty(), obligation)
-                .may_apply()
-        })
-    }
-
-    /// Evaluates whether the obligation `obligation` can be satisfied,
-    /// and returns `false` if not certain. However, this is not entirely
-    /// accurate if inference variables are involved.
-    pub fn evaluate_obligation_conservatively(&mut self,
-                                              obligation: &PredicateObligation<'tcx>)
-                                              -> bool
+                               -> EvaluationResult
     {
-        debug!("evaluate_obligation_conservatively({:?})",
-               obligation);
-
-        self.probe(|this, _| {
-            this.evaluate_predicate_recursively(TraitObligationStackList::empty(), obligation)
-                == EvaluatedToOk
-        })
-    }
+        debug!("evaluate_obligation({:?})", obligation);
 
-    /// Evaluates whether the obligation `obligation` can be satisfied and returns
-    /// an `EvaluationResult`.
-    pub fn evaluate_obligation_recursively(&mut self,
-                                           obligation: &PredicateObligation<'tcx>)
-                                           -> EvaluationResult
-    {
         self.probe(|this, _| {
             this.evaluate_predicate_recursively(TraitObligationStackList::empty(), obligation)
         })

src/librustc_traits/evaluate_obligation.rs

@@ -29,6 +29,6 @@ crate fn evaluate_obligation<'tcx>(
         let mut selcx = SelectionContext::new(&infcx);
         let obligation = Obligation::new(ObligationCause::dummy(), param_env, predicate);
 
-        selcx.evaluate_obligation_recursively(&obligation)
+        selcx.evaluate_obligation(&obligation)
     })
 }