Skip to content

Commit

Permalink
Allow atomic operations up to 32 bits
Browse files Browse the repository at this point in the history
The ARMv5te platform does not have instruction-level support for atomics, however the kernel provides [user space helpers](https://www.kernel.org/doc/Documentation/arm/kernel_user_helpers.txt) which can be used to perform atomic operations. When linked with `libc`, the atomic symbols needed by Rust will be provided, rather than CPU level intrinsics.

As this target is specifically `linux` and `gnueabi`, it is reasonable to assume the Linux Kernel and libc will be available for the target. There is a large performance penalty, as we are not using CPU level intrinsics, however this penalty is likely preferable to not having the target at all.

I have used this change in a custom target (along with `xargo`) to build `std`, as well as a number of higher level crates.
  • Loading branch information
jamesmunns committed Oct 2, 2017
1 parent 9ae6ed7 commit 1e26094
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/librustc_back/target/armv5te_unknown_linux_gnueabi.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,12 @@ pub fn target() -> TargetResult {

options: TargetOptions {
features: "+soft-float,+strict-align".to_string(),
// No atomic instructions on ARMv5
max_atomic_width: Some(0),

// Atomic operations provided when linked with libgcc.
// FIXME: If the following PR is merged, the atomic operations would be
// provided by compiler-builtins instead with no change of behavior:
// https://github.com/rust-lang-nursery/compiler-builtins/pull/115/files
max_atomic_width: Some(32),
abi_blacklist: super::arm_base::abi_blacklist(),
.. base
}
Expand Down

0 comments on commit 1e26094

Please sign in to comment.