Remove a loop which runs exactly once

AnthonyMikh · AnthonyMikh · commit 159d8a4154e9 · 2019-10-27T12:02:34.000+03:00
diff --git a/src/librustc_errors/emitter.rs b/src/librustc_errors/emitter.rs
@@ -1817,10 +1817,9 @@ impl FileWithAnnotatedLines {
                     // Every `|` that joins the beginning of the span (`___^`) to the end (`|__^`).
                     add_annotation_to_file(&mut output, file.clone(), line, ann.as_line());
                 }
-                if middle < ann.line_end - 1 {
-                    for line in ann.line_end - 1..ann.line_end {
-                        add_annotation_to_file(&mut output, file.clone(), line, ann.as_line());
-                    }
+                let line_end = ann.line_end - 1;
+                if middle < line_end {
+                    add_annotation_to_file(&mut output, file.clone(), line_end, ann.as_line());
                 }
             } else {
                 end_ann.annotation_type = AnnotationType::Singleline;

Original file line number	Diff line number	Diff line change
`@@ -1817,10 +1817,9 @@ impl FileWithAnnotatedLines {`
`1817`	`1817`	// Every `\|` that joins the beginning of the span (`___^`) to the end (`\|__^`).
`1818`	`1818`	`add_annotation_to_file(&mut output, file.clone(), line, ann.as_line());`
`1819`	`1819`	`}`
`1820`		`- if middle < ann.line_end - 1 {`
`1821`		`- for line in ann.line_end - 1..ann.line_end {`
`1822`		`- add_annotation_to_file(&mut output, file.clone(), line, ann.as_line());`
`1823`		`- }`
	`1820`	`+ let line_end = ann.line_end - 1;`
	`1821`	`+ if middle < line_end {`
	`1822`	`+ add_annotation_to_file(&mut output, file.clone(), line_end, ann.as_line());`
`1824`	`1823`	`}`
`1825`	`1824`	`} else {`
`1826`	`1825`	`end_ann.annotation_type = AnnotationType::Singleline;`