Skip to content

Commit 0f9af82

Browse files
committed
update the warning on as_command_mut
1 parent 95d232a commit 0f9af82

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/bootstrap/src/utils/exec.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,8 +203,9 @@ impl<'a> BootstrapCommand {
203203
/// Provides access to the stdlib Command inside.
204204
/// FIXME: This function should be eventually removed from bootstrap.
205205
pub fn as_command_mut(&mut self) -> &mut Command {
206-
// We don't know what will happen with the returned command, so we need to mark this
207-
// command as executed proactively.
206+
// We proactively mark this command as executed since we can't be certain how the returned
207+
// command will be handled. Caching must also be avoided here, as the inner command could be
208+
// modified externally without us being aware.
208209
self.mark_as_executed();
209210
self.cache_never();
210211
&mut self.command

0 commit comments

Comments
 (0)