Skip to content

Commit 0b0ccd4

Browse files
bjorn3bjorn3
committed
Fix miri
1 parent b754ef7 commit 0b0ccd4

11 files changed

+64
-19
lines changed

‎src/tools/miri/src/lib.rs

+1
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ extern crate rustc_index;
7171
extern crate rustc_middle;
7272
extern crate rustc_session;
7373
extern crate rustc_span;
74+
extern crate rustc_symbol_mangling;
7475
extern crate rustc_target;
7576
// Linking `rustc_driver` pulls in the required object code as the rest of the rustc crates are
7677
// shipped only as rmeta files.

‎src/tools/miri/src/shims/extern_static.rs

+7-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
//! Provides the `extern static` that this platform expects.
22
3+
use rustc_symbol_mangling::mangle_internal_symbol;
4+
35
use crate::*;
46

57
impl<'tcx> MiriMachine<'tcx> {
@@ -50,7 +52,11 @@ impl<'tcx> MiriMachine<'tcx> {
5052
// "__rust_alloc_error_handler_should_panic"
5153
let val = ecx.tcx.sess.opts.unstable_opts.oom.should_panic();
5254
let val = ImmTy::from_int(val, ecx.machine.layouts.u8);
53-
Self::alloc_extern_static(ecx, "__rust_alloc_error_handler_should_panic", val)?;
55+
Self::alloc_extern_static(
56+
ecx,
57+
&mangle_internal_symbol(*ecx.tcx, "__rust_alloc_error_handler_should_panic"),
58+
val,
59+
)?;
5460

5561
if ecx.target_os_is_unix() {
5662
// "environ" is mandated by POSIX.

‎src/tools/miri/src/shims/foreign_items.rs

+32-18
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ use rustc_middle::mir::interpret::AllocInit;
1212
use rustc_middle::ty::Ty;
1313
use rustc_middle::{mir, ty};
1414
use rustc_span::Symbol;
15+
use rustc_symbol_mangling::mangle_internal_symbol;
1516
use rustc_target::callconv::{Conv, FnAbi};
1617

1718
use self::helpers::{ToHost, ToSoft};
@@ -51,17 +52,18 @@ pub trait EvalContextExt<'tcx>: crate::MiriInterpCxExt<'tcx> {
5152

5253
// Some shims forward to other MIR bodies.
5354
match link_name.as_str() {
54-
"__rust_alloc_error_handler" => {
55+
name if name == mangle_internal_symbol(*this.tcx, "__rust_alloc_error_handler") => {
5556
// Forward to the right symbol that implements this function.
5657
let Some(handler_kind) = this.tcx.alloc_error_handler_kind(()) else {
5758
// in real code, this symbol does not exist without an allocator
5859
throw_unsup_format!(
5960
"`__rust_alloc_error_handler` cannot be called when no alloc error handler is set"
6061
);
6162
};
62-
let name = alloc_error_handler_name(handler_kind);
63+
let name =
64+
mangle_internal_symbol(*this.tcx, alloc_error_handler_name(handler_kind));
6365
let handler = this
64-
.lookup_exported_symbol(Symbol::intern(name))?
66+
.lookup_exported_symbol(Symbol::intern(&name))?
6567
.expect("missing alloc error handler symbol");
6668
return interp_ok(Some(handler));
6769
}
@@ -136,15 +138,29 @@ pub trait EvalContextExt<'tcx>: crate::MiriInterpCxExt<'tcx> {
136138
// Find it if it was not cached.
137139
let mut instance_and_crate: Option<(ty::Instance<'_>, CrateNum)> = None;
138140
helpers::iter_exported_symbols(tcx, |cnum, def_id| {
141+
if tcx.is_foreign_item(def_id) {
142+
// Skip over imports of items
143+
return interp_ok(());
144+
}
145+
139146
let attrs = tcx.codegen_fn_attrs(def_id);
147+
// FIXME use tcx.symbol_name(instance) instead
140148
let symbol_name = if let Some(export_name) = attrs.export_name {
141149
export_name
142-
} else if attrs.flags.contains(CodegenFnAttrFlags::NO_MANGLE) {
150+
} else if attrs.flags.contains(CodegenFnAttrFlags::NO_MANGLE)
151+
|| attrs.flags.contains(CodegenFnAttrFlags::RUSTC_STD_INTERNAL_SYMBOL)
152+
{
143153
tcx.item_name(def_id)
144154
} else {
145155
// Skip over items without an explicitly defined symbol name.
146156
return interp_ok(());
147157
};
158+
let symbol_name =
159+
if attrs.flags.contains(CodegenFnAttrFlags::RUSTC_STD_INTERNAL_SYMBOL) {
160+
Symbol::intern(&mangle_internal_symbol(tcx, symbol_name.as_str()))
161+
} else {
162+
symbol_name
163+
};
148164
if symbol_name == link_name {
149165
if let Some((original_instance, original_cnum)) = instance_and_crate {
150166
// Make sure we are consistent wrt what is 'first' and 'second'.
@@ -489,7 +505,9 @@ trait EvalContextExtPriv<'tcx>: crate::MiriInterpCxExt<'tcx> {
489505
}
490506

491507
// Rust allocation
492-
"__rust_alloc" | "miri_alloc" => {
508+
name if name == mangle_internal_symbol(*this.tcx, "__rust_alloc")
509+
|| name == "miri_alloc" =>
510+
{
493511
let default = |ecx: &mut MiriInterpCx<'tcx>| {
494512
// Only call `check_shim` when `#[global_allocator]` isn't used. When that
495513
// macro is used, we act like no shim exists, so that the exported function can run.
@@ -500,9 +518,8 @@ trait EvalContextExtPriv<'tcx>: crate::MiriInterpCxExt<'tcx> {
500518
ecx.check_rustc_alloc_request(size, align)?;
501519

502520
let memory_kind = match link_name.as_str() {
503-
"__rust_alloc" => MiriMemoryKind::Rust,
504521
"miri_alloc" => MiriMemoryKind::Miri,
505-
_ => unreachable!(),
522+
_ => MiriMemoryKind::Rust,
506523
};
507524

508525
let ptr = ecx.allocate_ptr(
@@ -516,15 +533,14 @@ trait EvalContextExtPriv<'tcx>: crate::MiriInterpCxExt<'tcx> {
516533
};
517534

518535
match link_name.as_str() {
519-
"__rust_alloc" => return this.emulate_allocator(default),
520536
"miri_alloc" => {
521537
default(this)?;
522538
return interp_ok(EmulateItemResult::NeedsReturn);
523539
}
524-
_ => unreachable!(),
540+
_ => return this.emulate_allocator(default),
525541
}
526542
}
527-
"__rust_alloc_zeroed" => {
543+
name if name == mangle_internal_symbol(*this.tcx, "__rust_alloc_zeroed") => {
528544
return this.emulate_allocator(|this| {
529545
// See the comment for `__rust_alloc` why `check_shim` is only called in the
530546
// default case.
@@ -543,7 +559,9 @@ trait EvalContextExtPriv<'tcx>: crate::MiriInterpCxExt<'tcx> {
543559
this.write_pointer(ptr, dest)
544560
});
545561
}
546-
"__rust_dealloc" | "miri_dealloc" => {
562+
name if name == mangle_internal_symbol(*this.tcx, "__rust_dealloc")
563+
|| name == "miri_dealloc" =>
564+
{
547565
let default = |ecx: &mut MiriInterpCx<'tcx>| {
548566
// See the comment for `__rust_alloc` why `check_shim` is only called in the
549567
// default case.
@@ -554,9 +572,8 @@ trait EvalContextExtPriv<'tcx>: crate::MiriInterpCxExt<'tcx> {
554572
let align = ecx.read_target_usize(align)?;
555573

556574
let memory_kind = match link_name.as_str() {
557-
"__rust_dealloc" => MiriMemoryKind::Rust,
558575
"miri_dealloc" => MiriMemoryKind::Miri,
559-
_ => unreachable!(),
576+
_ => MiriMemoryKind::Rust,
560577
};
561578

562579
// No need to check old_size/align; we anyway check that they match the allocation.
@@ -568,17 +585,14 @@ trait EvalContextExtPriv<'tcx>: crate::MiriInterpCxExt<'tcx> {
568585
};
569586

570587
match link_name.as_str() {
571-
"__rust_dealloc" => {
572-
return this.emulate_allocator(default);
573-
}
574588
"miri_dealloc" => {
575589
default(this)?;
576590
return interp_ok(EmulateItemResult::NeedsReturn);
577591
}
578-
_ => unreachable!(),
592+
_ => return this.emulate_allocator(default),
579593
}
580594
}
581-
"__rust_realloc" => {
595+
name if name == mangle_internal_symbol(*this.tcx, "__rust_realloc") => {
582596
return this.emulate_allocator(|this| {
583597
// See the comment for `__rust_alloc` why `check_shim` is only called in the
584598
// default case.

‎src/tools/miri/tests/fail/alloc/too_large.rs

+3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1+
#![feature(rustc_attrs)]
2+
13
extern "Rust" {
4+
#[rustc_std_internal_symbol]
25
fn __rust_alloc(size: usize, align: usize) -> *mut u8;
36
}
47

‎src/tools/miri/tests/fail/alloc/unsupported_big_alignment.rs

+3
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,10 @@
22
// because rustc does not support alignments that large.
33
// https://github.com/rust-lang/miri/issues/3687
44

5+
#![feature(rustc_attrs)]
6+
57
extern "Rust" {
8+
#[rustc_std_internal_symbol]
69
fn __rust_alloc(size: usize, align: usize) -> *mut u8;
710
}
811

‎src/tools/miri/tests/fail/alloc/unsupported_non_power_two_alignment.rs

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
// Test non-power-of-two alignment.
2+
3+
#![feature(rustc_attrs)]
4+
25
extern "Rust" {
6+
#[rustc_std_internal_symbol]
37
fn __rust_alloc(size: usize, align: usize) -> *mut u8;
48
}
59

‎src/tools/miri/tests/fail/data_race/dealloc_read_race1.rs

+3
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
// Avoid accidental synchronization via address reuse inside `thread::spawn`.
44
//@compile-flags: -Zmiri-address-reuse-cross-thread-rate=0
55

6+
#![feature(rustc_attrs)]
7+
68
use std::thread::spawn;
79

810
#[derive(Copy, Clone)]
@@ -12,6 +14,7 @@ unsafe impl<T> Send for EvilSend<T> {}
1214
unsafe impl<T> Sync for EvilSend<T> {}
1315

1416
extern "Rust" {
17+
#[rustc_std_internal_symbol]
1518
fn __rust_dealloc(ptr: *mut u8, size: usize, align: usize);
1619
}
1720

‎src/tools/miri/tests/fail/data_race/dealloc_read_race2.rs

+3
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
// Avoid accidental synchronization via address reuse inside `thread::spawn`.
44
//@compile-flags: -Zmiri-address-reuse-cross-thread-rate=0
55

6+
#![feature(rustc_attrs)]
7+
68
use std::thread::spawn;
79

810
#[derive(Copy, Clone)]
@@ -12,6 +14,7 @@ unsafe impl<T> Send for EvilSend<T> {}
1214
unsafe impl<T> Sync for EvilSend<T> {}
1315

1416
extern "Rust" {
17+
#[rustc_std_internal_symbol]
1518
fn __rust_dealloc(ptr: *mut u8, size: usize, align: usize);
1619
}
1720

‎src/tools/miri/tests/fail/data_race/dealloc_write_race1.rs

+3
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
// Avoid accidental synchronization via address reuse inside `thread::spawn`.
44
//@compile-flags: -Zmiri-address-reuse-cross-thread-rate=0
55

6+
#![feature(rustc_attrs)]
7+
68
use std::thread::spawn;
79

810
#[derive(Copy, Clone)]
@@ -12,6 +14,7 @@ unsafe impl<T> Send for EvilSend<T> {}
1214
unsafe impl<T> Sync for EvilSend<T> {}
1315

1416
extern "Rust" {
17+
#[rustc_std_internal_symbol]
1518
fn __rust_dealloc(ptr: *mut u8, size: usize, align: usize);
1619
}
1720
pub fn main() {

‎src/tools/miri/tests/fail/data_race/dealloc_write_race2.rs

+3
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
// Avoid accidental synchronization via address reuse inside `thread::spawn`.
44
//@compile-flags: -Zmiri-address-reuse-cross-thread-rate=0
55

6+
#![feature(rustc_attrs)]
7+
68
use std::thread::spawn;
79

810
#[derive(Copy, Clone)]
@@ -12,6 +14,7 @@ unsafe impl<T> Send for EvilSend<T> {}
1214
unsafe impl<T> Sync for EvilSend<T> {}
1315

1416
extern "Rust" {
17+
#[rustc_std_internal_symbol]
1518
fn __rust_dealloc(ptr: *mut u8, size: usize, align: usize);
1619
}
1720
pub fn main() {

‎src/tools/miri/tests/pass/function_calls/exported_symbol.rs

+2
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ fn main() {
4040

4141
extern "Rust" {
4242
fn bar() -> i32;
43+
#[rustc_std_internal_symbol]
4344
fn baz() -> i32;
4445
fn qux() -> i32;
4546
}
@@ -63,6 +64,7 @@ fn main() {
6364

6465
extern "C" {
6566
fn bar() -> i32;
67+
#[rustc_std_internal_symbol]
6668
fn baz() -> i32;
6769
fn qux() -> i32;
6870
}

0 commit comments

Comments
 (0)