Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
It's possible for a reader to have a short read, and there's no reason the task should fail in this scenario. By using fill(), this has a stronger guarantee that the buffer will get filled with data.
- Loading branch information
02dab5a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from huonw
at alexcrichton@02dab5a
02dab5a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alexcrichton/rust/io-fill = 02dab5a into auto
02dab5a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexcrichton/rust/io-fill = 02dab5a merged ok, testing candidate = e06348e
02dab5a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/4856
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/4852
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/3949
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3957
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/4955
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/4043
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/4050
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/4957
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/4043
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/4048
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/4116
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1847
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/4954
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/4054
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/4062
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/4716
02dab5a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = e06348e