Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to specify aliasing model for Miri #1074

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GoldsteinE
Copy link

Very useful for comparing stacked borrows and tree borrows.

An example for testing:

fn main() {
    let val = [1u8, 2];
    let ptr = &val[0] as *const u8;
    let _val = unsafe { *ptr.add(1) };
}

is valid under Tree Borrows, but not under Stacked Borrows.

UI looks like this:

image

@GoldsteinE GoldsteinE changed the title Allow user to specify aliasing mode for Miri Allow user to specify aliasing model for Miri Jul 22, 2024
@GoldsteinE
Copy link
Author

The one problem I have with my implementation is that this knob is not saved when sharing via link. I could easily fix this, but it will add an extra &aliasing_model=stacked at the end of every single URL. Alternatively, I could make “Share” omit unchanged parameters, but I suppose there’s a reason why it isn’t this way already.

@GoldsteinE
Copy link
Author

@shepmaster Hi! Looking at the commit history, I think I should ask you to review these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant