Skip to content
This repository was archived by the owner on Oct 9, 2018. It is now read-only.

Commit 6dbf093

Browse files
committed
Lift up FIXMEs
1 parent 0370524 commit 6dbf093

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

style/braces.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
% Braces, semicolons, and commas
1+
% Braces, semicolons, and commas [FIXME: needs RFC]
22

3-
### Opening braces always go on the same line. [FIXME: needs RFC]
3+
### Opening braces always go on the same line.
44

55
``` rust
66
fn foo() {
@@ -28,7 +28,7 @@ frob(|x| {
2828
})
2929
```
3030

31-
### `match` arms get braces, except for single-line expressions. [FIXME: needs RFC]
31+
### `match` arms get braces, except for single-line expressions.
3232

3333
``` rust
3434
match foo {
@@ -40,7 +40,7 @@ match foo {
4040
}
4141
```
4242

43-
### `return` statements get semicolons. [FIXME: needs RFC]
43+
### `return` statements get semicolons.
4444

4545
``` rust
4646
fn foo() {
@@ -54,7 +54,7 @@ fn foo() {
5454
}
5555
```
5656

57-
### Trailing commas [FIXME: needs RFC]
57+
### Trailing commas
5858

5959
> **[FIXME]** We should have a guideline for when to include trailing
6060
> commas in `struct`s, `match`es, function calls, etc.

style/features.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
## `return`
1+
## `return` [FIXME: needs RFC]
22

33
Terminate `return` statements with semicolons:
44

style/imports.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
% Imports
1+
% Imports [FIXME: needs RFC]
22

33
The imports of a crate/module should consist of the following
44
sections, in order, with a blank space between each:
@@ -26,7 +26,7 @@ use mylib::webserver;
2626
pub use self::types::Webdata;
2727
```
2828

29-
### Avoid `use *`, except in tests. [FIXME: needs RFC]
29+
### Avoid `use *`, except in tests.
3030

3131
Glob imports have several downsides:
3232
* They make it harder to tell where names are bound.
@@ -36,7 +36,7 @@ Glob imports have several downsides:
3636
When writing a [`test` submodule](../testing/README.md), importing `super::*` is appropriate
3737
as a convenience.
3838

39-
### Prefer fully importing types/traits while module-qualifying functions. [FIXME: needs RFC]
39+
### Prefer fully importing types/traits while module-qualifying functions.
4040

4141
For example:
4242

style/organization.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1-
% Organization
1+
% Organization [FIXME: needs RFC]
22

33
> **[FIXME]** What else?
44
5-
### Reexport the most important types at the crate level. [FIXME: needs RFC]
5+
### Reexport the most important types at the crate level.
66

77
Crates `pub use` the most common types for convenience, so that clients do not
88
have to remember or write the crate's module hierarchy to use these types.
99

10-
### Define types and operations together. [FIXME: needs RFC]
10+
### Define types and operations together.
1111

1212
Type definitions and the functions/methods that operate on them should be
1313
defined together in a single module, with the type appearing above the

0 commit comments

Comments
 (0)