Skip to content

Conversation

@mcarton
Copy link
Contributor

@mcarton mcarton commented Mar 10, 2016

Ref rust-lang/rust#31710.
For tomorrow’s nightly, don’t bother building it today Travis.

@llogiq
Copy link
Contributor

llogiq commented Mar 10, 2016

Travis did bother anyway 😃

@Manishearth Manishearth reopened this Mar 11, 2016
@Manishearth
Copy link
Member

New failures:

   Compiling semver v0.2.3

   Compiling clippy v0.0.49 (file:///home/travis/build/Manishearth/rust-clippy)

src/cyclomatic_complexity.rs:128:21: 128:32 error: unresolved enum variant, struct or const `TyFnDef` [E0419]

src/cyclomatic_complexity.rs:128                     ty::TyFnDef(_, _, ty) | ty::TyFnPtr(ty) if ty.sig.skip_binder().output.diverges() => {

                                                     ^~~~~~~~~~~

src/cyclomatic_complexity.rs:128:21: 128:32 help: run `rustc --explain E0419` to see a detailed explanation

src/cyclomatic_complexity.rs:128:45: 128:56 error: unresolved enum variant, struct or const `TyFnPtr` [E0419]

src/cyclomatic_complexity.rs:128                     ty::TyFnDef(_, _, ty) | ty::TyFnPtr(ty) if ty.sig.skip_binder().output.diverges() => {

                                                                             ^~~~~~~~~~~

src/cyclomatic_complexity.rs:128:45: 128:56 help: run `rustc --explain E0419` to see a detailed explanation

src/eta_reduction.rs:63:21: 63:32 error: unresolved enum variant, struct or const `TyFnDef` [E0419]

src/eta_reduction.rs:63                     ty::TyFnDef(_, _, fn_ty) | ty::TyFnPtr(fn_ty) => {

                                            ^~~~~~~~~~~

src/eta_reduction.rs:63:21: 63:32 help: run `rustc --explain E0419` to see a detailed explanation

src/eta_reduction.rs:63:48: 63:59 error: unresolved enum variant, struct or const `TyFnPtr` [E0419]

src/eta_reduction.rs:63                     ty::TyFnDef(_, _, fn_ty) | ty::TyFnPtr(fn_ty) => {

                                                                       ^~~~~~~~~~~

src/eta_reduction.rs:63:48: 63:59 help: run `rustc --explain E0419` to see a detailed explanation

src/derive.rs:158:29: 158:54 error: no associated item named `TyFnPtr` found for type `rustc::middle::ty::sty::TypeVariants<'_>` in the current scope

src/derive.rs:158                             TypeVariants::TyFnPtr(..) => {

                                              ^~~~~~~~~~~~~~~~~~~~~~~~~

src/mut_reference.rs:57:9: 57:49 error: no associated item named `TyFnDef` found for type `rustc::middle::ty::sty::TypeVariants<'_>` in the current scope

src/mut_reference.rs:57         TypeVariants::TyFnDef(_, _, ref fn_type) | TypeVariants::TyFnPtr(ref fn_type) => {

                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/mut_reference.rs:57:52: 57:86 error: no associated item named `TyFnPtr` found for type `rustc::middle::ty::sty::TypeVariants<'_>` in the current scope

src/mut_reference.rs:57         TypeVariants::TyFnDef(_, _, ref fn_type) | TypeVariants::TyFnPtr(ref fn_type) => {

                                                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/mut_reference.rs:58:31: 58:42 error: the type of this value must be known in this context

src/mut_reference.rs:58             let parameters = &fn_type.sig.skip_binder().inputs;

                                                      ^~~~~~~~~~~

src/mut_reference.rs:59:63: 59:80 error: the type of this value must be known in this context

src/mut_reference.rs:59             for (argument, parameter) in arguments.iter().zip(parameters.iter()) {

                                                                                      ^~~~~~~~~~~~~~~~~

src/mut_reference.rs:60:23: 60:36 error: the type of this value must be known in this context

src/mut_reference.rs:60                 match parameter.sty {

                                              ^~~~~~~~~~~~~

src/mut_reference.rs:63:60: 63:73 error: the type of this value must be known in this context

src/mut_reference.rs:63                         if let ExprAddrOf(MutMutable, _) = argument.node {


@mcarton
Copy link
Contributor Author

mcarton commented Mar 11, 2016

@Manishearth patience, the right nightly hasn’t been release yet, 😛
Travis has

$ rustc --version
rustc 1.9.0-nightly (cc62db802 2016-03-09)

rust-lang/rust#31710 was merged yesterday (2016-03-10) at 7:41 AM GTM+1.

mcarton added a commit that referenced this pull request Mar 11, 2016
Rustup to 1.9.0-nightly (c9629d6 2016-03-10)
@mcarton mcarton merged commit f255734 into rust-lang:master Mar 11, 2016
@mcarton mcarton deleted the rustup branch March 11, 2016 13:23
match parameter.sty {
TypeVariants::TyRef(_, TypeAndMut {mutbl: MutImmutable, ..}) |
TypeVariants::TyRawPtr(TypeAndMut {mutbl: MutImmutable, ..}) => {
if let ExprAddrOf(MutMutable, _) = argument.node {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this code using TypeVariants directly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, I was like that. I don’t dislike it. I left it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but, it should be using ty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants