[beta] Backport of #6375 - field_reassign_with_default fix - #6537
Merged
Conversation
The default value for a field type does not necessarily match the default value for that field in the struct Default.
There is already an assertion that consecutive lines assign to a struct field.
|
r? @ebroto (rust-highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
ebroto
approved these changes
Jan 2, 2021
ebroto
left a comment
ebroto
left a comment
Contributor
There was a problem hiding this comment.
With the pinned nightly we can test backports to our beta branch now tada
So, to make sure I understand, I should go ahead and merge this to our beta branch before we open the PR against rust-lang/rust?
ebroto
added
S-waiting-on-author
Member
Author
|
Yes, you should be able to |
Contributor
|
@bors r+ |
Contributor
|
📌 Commit fa75f63 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the pinned nightly we can test backports to our beta branch now 🎉
cc #6515
changelog: beta 1.50: Backport of private fields fix in [
field_reassign_with_default] lints