Skip to content

Rename tables to typecheck_result() #6131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Rename tables to typecheck_result() #6131

merged 2 commits into from
Oct 9, 2020

Conversation

ambroisie
Copy link
Contributor

While working on #6130, I noticed that part of the documentation was updated to use LateContext::typeck_results, but the paragraph still referred to the old tables field of LateContext.


Please keep the line below
changelog: none

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 7, 2020
Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>
@flip1995
Copy link
Member

flip1995 commented Oct 9, 2020

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Oct 9, 2020

📌 Commit 326090d has been approved by flip1995

@bors
Copy link
Contributor

bors commented Oct 9, 2020

⌛ Testing commit 326090d with merge e87c028...

@bors
Copy link
Contributor

bors commented Oct 9, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing e87c028 to master...

@bors bors merged commit e87c028 into rust-lang:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants