Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for #5238 #5242

Merged
merged 1 commit into from
Mar 2, 2020
Merged

add test for #5238 #5242

merged 1 commit into from
Mar 2, 2020

Conversation

matthiaskrgr
Copy link
Member

changelog: none

@matthiaskrgr
Copy link
Member Author

This is currently blocked on rust-lang/rust#69562

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 2, 2020
@JohnTitor
Copy link
Member

Unblocked now, it's ready to go.

@matthiaskrgr
Copy link
Member Author

r? @JohnTitor

@flip1995
Copy link
Member

flip1995 commented Mar 2, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 2, 2020

📌 Commit 1e29b36 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Mar 2, 2020

⌛ Testing commit 1e29b36 with merge ce58f73...

bors added a commit that referenced this pull request Mar 2, 2020
@bors
Auto merge of #5242 - matthiaskrgr:5238_test, r=flip1995
ce58f73 
add test for #5238

changelog: none
@bors
Copy link
Collaborator

bors commented Mar 2, 2020

💔 Test failed - checks-action_test

@flip1995
Copy link
Member

flip1995 commented Mar 2, 2020

Seems like some change to rustc produced another test-fail?

@flip1995
Copy link
Member

flip1995 commented Mar 2, 2020

@bors retry

@bors
Copy link
Collaborator

bors commented Mar 2, 2020

⌛ Testing commit 1e29b36 with merge a94b2c1...

@bors
Copy link
Collaborator

bors commented Mar 2, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing a94b2c1 to master...

@bors bors merged commit a94b2c1 into rust-lang:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthiaskrgr @JohnTitor @flip1995 @bors