New lint: zst_offset #4816
Merged
New lint: zst_offset #4816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
added
the
S-waiting-on-review
Member
|
Seems occurred an ICE on dogfooding |
flip1995
reviewed
Nov 15, 2019
Contributor
Author
|
@flip1995 r? |
phansch
approved these changes
Nov 16, 2019
Contributor
phansch
left a comment
phansch
left a comment
There was a problem hiding this comment.
r=me once Clippy builds again
Member
|
@bors r=phansch |
Contributor
|
📌 Commit c21b198 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 23, 2019
New lint: zst_offset This fixes #4813 changelog: add `zst_offset` lint
Contributor
Member
|
@bors retry for queue prio |
bors
added a commit
that referenced
this pull request
Nov 23, 2019
Rollup of 4 Pull requests with new lints Rollup of pull requests - #4816 (New lint: zst_offset) - #4814 (New lint: Implement ifs_same_cond_fn) - #4807 (Add `large_stack_arrays` lint) - #4806 (Issue/4623) changelog: add [`zst_offset`] lint changelog: New lint: [`ifs_same_cond_fn`] cahngelog: Add new lint [large_stack_arrays] changelog: added lint [`tabs_in_doc_comments`]
dario23
reviewed
Nov 24, 2019
| @@ -0,0 +1,9 @@ | |||
| error[E0606]: casting `&i32` as `*const u8` is invalid | |||
Contributor
There was a problem hiding this comment.
shouldn't there be errors about offset calculations using x here instead of casting errors for y?
CAD97
reviewed
Nov 24, 2019
| /// | ||
| /// **Example:** | ||
| /// ```ignore | ||
| /// unsafe { (&() as *const ()).offest(1) }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4813
changelog: add
zst_offsetlint