Skip to content

Add rust-toolchain for clippy_dev #3885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from Apr 8, 2019
Merged

Add rust-toolchain for clippy_dev #3885

merged 3 commits into from Apr 8, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 15, 2019

AFAIK, clippy_dev is supposed to be built on stable. (This is why it's not a [bin] inside the root Cargo.toml.) This adds a rust-toolchain file for easy switching.

@phansch
Copy link
Member

phansch commented Mar 15, 2019

IIRC, when I added it, I was unable to make it work on stable due to interactions with the Cargo.toml in the root directory. Maybe that's fixed now?

@ghost
Copy link
Author

ghost commented Mar 19, 2019

It seems to work on CI but should clippy_dev be listed as a dev dependency? With this change it gets built twice. Once with master as a dependency and again with stable when it's actually used. IMO we should remove it from the root Cargo.toml and just let it get built on demand when people run util/dev.

@phansch
Copy link
Member

phansch commented Mar 19, 2019

IMO we should remove it from the root Cargo.toml and just let it get built on demand when people run util/dev.

Sounds good =)

@phansch
Copy link
Member

phansch commented Apr 8, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Apr 8, 2019

📌 Commit 63cd54b has been approved by phansch

@bors
Copy link
Contributor

bors commented Apr 8, 2019

⌛ Testing commit 63cd54b with merge e226f17...

bors added a commit that referenced this pull request Apr 8, 2019
Add rust-toolchain for clippy_dev

AFAIK, `clippy_dev` is supposed to be built on stable. (This is why it's not a `[bin]` inside the root `Cargo.toml`.) This adds a `rust-toolchain` file for easy switching.
@bors
Copy link
Contributor

bors commented Apr 8, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing e226f17 to master...

@bors bors merged commit 63cd54b into rust-lang:master Apr 8, 2019
@ghost ghost deleted the clippy_dev_toolchain branch May 11, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants