Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace cfg_attr(rustfmt... with rustfmt::skip #2823

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Replace cfg_attr(rustfmt... with rustfmt::skip #2823

merged 1 commit into from
Aug 8, 2018

Conversation

flip1995
Copy link
Member

Fixes #2822

thingies replaced!

@oli-obk
Copy link
Contributor

oli-obk commented May 30, 2018

still triggering some errors on travis

@flip1995
Copy link
Member Author

This is a rustc problem. If you enable the rust_2018_preview and the tool_attributes feature, the tool_attributes stop working, see playground. I'm looking into this tomorrow and either open a PR or an issue.

@mati865
Copy link
Contributor

mati865 commented Jun 1, 2018

😞
The migration took it's first casualty.

@flip1995 flip1995 mentioned this pull request Jun 1, 2018
Closed
@mati865
Copy link
Contributor

mati865 commented Jul 30, 2018

This PR will be unblocked when rust-lang/rust#52841 lands.

@phansch phansch closed this Aug 6, 2018
@phansch phansch reopened this Aug 6, 2018
@mati865
Copy link
Contributor

mati865 commented Aug 8, 2018

CI passed

@oli-obk oli-obk merged commit d722489 into rust-lang:master Aug 8, 2018
@flip1995 flip1995 deleted the thingies_things branch September 24, 2018 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flip1995 @oli-obk @mati865 @phansch