Better check for assign_op_pattern in const context
#15532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`assign_op_pattern` can be used in a `const` context if the trait definition as well as the implementation of the corresponding `Assign` pattern is `const` as well.
rustbot
added
the
S-waiting-on-review
flip1995
approved these changes
Aug 22, 2025
Member
flip1995
left a comment
flip1995
left a comment
There was a problem hiding this comment.
Nice! Thanks! Ideally we'd include this in the Clippy->Rust sync. However, the Rust PR is already in the bors queue. Should it fail there, I'll include this. Otherwise, it'll have to wait until the next sync 🤷
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assign_op_patterncan be used in aconstcontext if the trait definition as well as the implementation of the correspondingAssignpattern isconstas well.The lint was temporarily deactivated in the compiler repository for all
constcontexts to avoid false positives when operators were potentially constified. This reenables it when appropriate now that the repositories have been synced.Closes #15285
changelog: [
assign_op_pattern]: trigger inconstcontexts when appropriater? @flip1995