Skip to content

Extend cargo dev rename_lint #14633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 16, 2025
Merged

Extend cargo dev rename_lint #14633

merged 3 commits into from
May 16, 2025

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Apr 16, 2025 •
edited by rustbot
Loading

Based on #14616

Extends rename_lint to handle more cases and makes update_lints sort deprecated_lints.rs.

changelog: None

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 16, 2025
@rustbot

This comment has been minimized.

Sign in to view
@samueltardieu
Copy link
Contributor

Since it's waiting on #13223 and I'll be AFK for a while, reassigning similarly to #13223
r? @flip1995

@rustbot rustbot assigned flip1995 and unassigned samueltardieu Apr 17, 2025
@Jarcho Jarcho mentioned this pull request Apr 24, 2025
Open
@Jarcho
Copy link
Contributor Author

Jarcho commented Apr 24, 2025

Since @flip1995 is busy r? clippy

@rustbot rustbot assigned y21 and unassigned flip1995 Apr 24, 2025
@Jarcho Jarcho added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Apr 24, 2025
Jarcho added 3 commits May 16, 2025 06:20
@Jarcho
Improve cargo dev rename_lint
44681fd 
* rename test files inside directories and ui-toml tests
* rename tests prefixed with the lint's name
* better module path renaming when renaming the lint's module
* partially delete lint files when uplifting
* rename ui_test error markers
@Jarcho
clippy_dev: order deprecated_lints.rs in update_lints
b3f4902
@Jarcho
clippy_dev: Fix previous renames in rename_lint
13b070e
@Jarcho Jarcho removed the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label May 16, 2025
samueltardieu
samueltardieu approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also tested it and it seems to work as expected.

@samueltardieu samueltardieu added this pull request to the merge queue May 16, 2025
Merged via the queue into rust-lang:master with commit 604b7b0 May 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueltardieu samueltardieu samueltardieu approved these changes

Assignees

@y21 y21

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jarcho @rustbot @samueltardieu @flip1995 @y21