Skip to content

Conversation

@ojeda
Copy link
Contributor

@ojeda ojeda commented Jul 1, 2024

Although manual_inspect's PR started some months ago, the lint is only available in the current nightly (1.81.0), rather than 1.78.0.

changelog: [`manual_inspect`]: fix `clippy::version` from 1.78.0 to 1.81.0

Although `manual_inspect`'s PR started some months ago, the lint is only
available in the current nightly (1.81.0), rather than 1.78.0.

Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
@rustbot
Copy link
Collaborator

rustbot commented Jul 1, 2024

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 1, 2024
@y21
Copy link
Member

y21 commented Jul 1, 2024

Thanks!

@bors r+

It's not uncommon for these version attributes to end up outdated on nightly, but they always get corrected as part of the changelog PR, so it's normally fine that they're incorrect (although I suppose that can still be misleading on the nightly lints page)

@bors
Copy link
Contributor

bors commented Jul 1, 2024

📌 Commit eb1b24a has been approved by y21

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 1, 2024

⌛ Testing commit eb1b24a with merge f24a870...

@bors
Copy link
Contributor

bors commented Jul 1, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: y21
Pushing f24a870 to master...

@bors bors merged commit f24a870 into rust-lang:master Jul 1, 2024
@ojeda
Copy link
Contributor Author

ojeda commented Jul 1, 2024

Ah, I didn't know that, sorry -- that is good to know, thanks!

Yeah, it can be confusing, e.g. I typically share a link to the new lint when I do cleanups in the kernel for nightly. Hmm... perhaps it could say there nightly or similar until the version is fixed? (like in rustc there is now a CURRENT_RUSTC_VERSION placeholder).

@ojeda ojeda deleted the manual_inspect_nightly branch July 1, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants