Update ui test crate #11239
Update ui test crate #11239
Conversation
|
r? @Alexendoo (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Alexendoo
added
S-blocked
|
☔ The latest upstream changes (presumably #11250) made this pull request unmergeable. Please resolve the merge conflicts. |
|
If you want to try out the new progress bar feature, use A notable difference (without |
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
Ok, actually ready now 🙃 |
|
☔ The latest upstream changes (presumably #10843) made this pull request unmergeable. Please resolve the merge conflicts. |
|
This fails to run on my laptop, it hits It's 2 cores/2 threads so it's not running much in parallel, it seems to be opening a growing number of pipes according to |
|
I fixed the pipe leak (i'll bump the minor version of ui test in the Cargo.toml here to pull it in), but miri has the same issue for low thread/process limits. Part of the problem seems to be, that it's per process tree, not per process. So all the clippy processes running at the same time seem to be sharing a single limit. |
|
☔ The latest upstream changes (presumably #11305) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Nice, runs fine now I've noticed it's quite a bit slower, measuring it with: hyperfine -L commit 7c595b4599d546dc5f36bc4bebbbf8ad454fed62,ui_test \
--prepare 'git checkout {commit}' \
--warmup 2 \
-n '{commit}' \
'cargo uitest'x86_64-pc-windows-msvc, 6 cores/12 threads aarch64-unknown-linux-gnu, 4 cores/4 threads |
|
I'll investigate, but I won't get to that in the next few weeks as I'm going on vacation starting this weekend. |
|
looks like there were two separate regressions: |
|
The performance issue has been found and resolved. |
|
☔ The latest upstream changes (presumably #11318) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Very nice, it's now faster than the current version |
…y created somewhere in the test folder
Update ui test crate This update also removes the `//`@run-rustfix`` flag, and just runs rustfix on all tests. This means I had to opt out of running rustfix on ~100 tests, but it also allowed me to remove the rustfix coverage check entirely, as it is now effectively builtin. changelog: update ui-test crate to 0.13 (automatically runs rustfix on all tests)
|
💔 Test failed - checks-action_test |
|
hmm... the mac os test runner passes |
|
Ready again. I also checked (manually) and haven't found any other flags being used in clippy CI |
|
@bors r=Alexendoo,flip1995 |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Do not bless by default in ui tests This restores the default behaviour to check the `.stderr`, it was changed in #11239 to bless by default in `cargo test` (unless in github actions), but check by default in `cargo uitest` which is fairly confusing It also meant `cargo uitest -F internal` no longer worked `--bless` prevents the use of `Args::test` but we can look at reintegrating with that after `@oli-obk's` vacation r? `@flip1995` changelog: none
This update also removes the
//@run-rustfixflag, and just runs rustfix on all tests. This means I had to opt out of running rustfix on ~100 tests, but it also allowed me to remove the rustfix coverage check entirely, as it is now effectively builtin.changelog: update ui-test crate to 0.13 (automatically runs rustfix on all tests)