[match_same_arms]: don't lint if non_exhaustive_omitted_patterns
#10946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
r? @xFrednet (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Contributor
|
Hey @blyxyas, do you want to take a look at this PR? :) |
Member
|
Yeehaw 🤠 (Yes) |
Contributor
|
I love how much fun you're having with the comments =^.^= |
blyxyas
requested changes
Jun 13, 2023
Member
blyxyas
left a comment
blyxyas
left a comment
There was a problem hiding this comment.
Other than that, everything's good, thanks!
(What a hard PR to review)
Centri3
force-pushed
the
match_same_arms
branch
2 times, most recently
from
ce51b5c to
8cd122d
Compare
xFrednet
reviewed
Jun 14, 2023
Contributor
xFrednet
left a comment
xFrednet
left a comment
There was a problem hiding this comment.
I like the idea, but I think we should make the lint suppression more fine-grained :)
blyxyas
reviewed
Jun 14, 2023
xFrednet
approved these changes
Jun 15, 2023
Contributor
|
LGTM, thank you for this nice update :D @bors r=blyxyas,xFrednet |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10327
changelog: [
match_same_arms]: Don't lint ifnon_exhaustive_omitted_patternsiswarnordeny