Restrict suggestion of deriving Default for enums to MSRV 1.62. #10164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
r? @Alexendoo (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Contributor
Author
|
r? @llogiq |
khuey
force-pushed
the
default_enum_unit_variant_msrv
branch
from
5d58214 to
6433d79
Compare
Contributor
|
Thank you! @bors r+ |
Contributor
Contributor
bors
added a commit
that referenced
this pull request
Jan 5, 2023
Restrict suggestion of deriving Default for enums to MSRV 1.62. See https://blog.rust-lang.org/2022/06/30/Rust-1.62.0.html#default-enum-variants
Contributor
|
💔 Test failed - checks-action_test |
Contributor
Author
|
If that failure is me I don't know what to do about it. |
Contributor
|
Ah, I missed that you had the @bors retry |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://blog.rust-lang.org/2022/06/30/Rust-1.62.0.html#default-enum-variants
changelog: none